New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lessons 82+ are 404 #11

Open

metareeff opened this issue Aug 14, 2020 · 1 comment

metareeff commented Aug 14, 2020

Lesson links are broken

Nick-Hope commented Jul 22, 2021

All these broken links and missing resources were driving me crazy until I realized what was going on...

The links in the 'master' drop-down menu are different, depending on where you open it from. If you open the menu from https://github.com/iamshaunjp/modern-javascript then the link to lesson-82 will take you to the correct place, which in this case is https://github.com/iamshaunjp/modern-javascript/tree/lesson-82

However if you were to open the 'master' menu from elsewhere in the tree such as https://github.com/iamshaunjp/modern-javascript/blob/lesson-61/chapter_7/sandbox.js then the 'lesson-100' link will take you to https://github.com/iamshaunjp/modern-javascript/blob/lesson-82/chapter_7/sandbox.js which does not exist, so you get a 404-page not found error.

It looks like you can open that 'master' menu from any 'lesson-XX' level in the tree and the links will be found correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment