Skip to content
This repository has been archived by the owner on Mar 22, 2021. It is now read-only.

Only default store view is being regenerated #19

Open
Frits1980 opened this issue Jul 14, 2017 · 3 comments
Open

Only default store view is being regenerated #19

Frits1980 opened this issue Jul 14, 2017 · 3 comments

Comments

@Frits1980
Copy link

If I remove line 77 from \vendor\iazel\module-regen-product-url\Iazel\RegenProductUrl\Console\Command\RegenerateProductUrlCommand.php
if($store_id === Store::DEFAULT_STORE_ID)

it works perfectly for every store view. As soon as I put it back only the default store view is being regenerated.

@mkor
Copy link

mkor commented Aug 18, 2017

In the current version, that is line #92

It should be replaced by:

        if($store_id !== Store::DEFAULT_STORE_ID)

(otherwise, it will always regenerate for the DEFAULT storeview)

ericrisler added a commit to myntpartners/magento2-regenurl that referenced this issue Aug 30, 2017
ericrisler added a commit to myntpartners/magento2-regenurl that referenced this issue Aug 30, 2017
* fix-19:
  for for iazel#19
@peterjaap
Copy link

+1!

@peterjaap
Copy link

This is fixed in my fork, amongst other issues https://github.com/peterjaap/magento2-regenurl

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants