Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextShimmer re-renders even if text stays the same #120

Open
pumuckelo opened this issue Feb 5, 2025 · 0 comments
Open

TextShimmer re-renders even if text stays the same #120

pumuckelo opened this issue Feb 5, 2025 · 0 comments

Comments

@pumuckelo
Copy link

TextShimmer component is not memoized. Even if the children / text stays the same, the animation restarts if the parent component re-renders.

Simply doing

const MemoizedTextShimmer = React.memo(TextShimmer);

fixes the issue but I think this should be the default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pumuckelo