Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FeedSource, FeedTransformRules and FeedRetrievalMethod #380

Open
binh-dam-ibigroup opened this issue May 5, 2021 · 0 comments
Open

Comments

@binh-dam-ibigroup
Copy link
Contributor

Original comment by @evansiroky: #371 (review)

I think we may want to rethink whether we should have the transform rules be a list within the FeedSource object. I think it deserves its own mongo collection because it is probably unnecessary to fetch all transformation data whenever a feed source is fetched. Also, it might also make sense to combine the FeedTransformRules, FeedRetrievalMethod and FeedTransformation classes together into a single FeedTransformation class. These design decisions were made prior to this PR, but I think moving forward, we should seriously consider refactoring this and avoid making additional lists within model classes unless a very small amount of data is expected within these lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant