Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check OTP plan object from response #128

Open
binh-dam-ibigroup opened this issue Dec 30, 2020 · 0 comments
Open

Check OTP plan object from response #128

binh-dam-ibigroup opened this issue Dec 30, 2020 · 0 comments

Comments

@binh-dam-ibigroup
Copy link
Collaborator

Observed behavior

NullPointerExceptions are thrown by OTP Middleware at CheckMonitoredTrip#makeOTPRequestAndUpdateMatchingItinerary when OTP does not find a plan for a MonitoredTrip for which a plan was found in the past.

This may happen when approaching holidays when trips that normally happen are removed from the schedule for specific days.

Expected behavior

No null pointer exceptions should be thrown in such situations.

Steps to reproduce the problem

Using FDOT and Friday, Jan. 1, 2021 as an example:

  • Create a weekday itinerary that involves SunRail, and monitor Friday only. (SunRail does not operate on holidays)
  • During the week leading to the holiday, run the CheckMonitoredTrip job
  • A NullPointerException occurs at the beginning of the for loop in CheckMonitoredTrip#makeOTPRequestAndUpdateMatchingItinerary

Any special notes on configuration used

No special config used.

Version of otp-middleware and/or OpenTripPlanner if applicable (exact commit hash or branch name)

Latest dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant