Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Utils to ensure they are throwing exceptions and not failing silently/returning null #51

Open
landonreed opened this issue Aug 3, 2020 · 0 comments
Open

Review Utils to ensure they are throwing exceptions and not failing silently/returning null #51

landonreed opened this issue Aug 3, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@landonreed
Copy link
Contributor

landonreed commented Aug 3, 2020 •
edited
Loading

A number of methods can return null which can result in NPEs (e.g., OtpDispatcher#sendOtpRequest and some JSON/Date utils). I would prefer for this method to throw a non-runtime exception if the request failed so that code that uses this method can properly account for times when an OTP request fails.

Originally posted by @evansiroky in https://github.com/ibi-group/otp-middleware/diffs

Also: #45 (comment)
@landonreed landonreed mentioned this issue Aug 3, 2020
Merged
5 tasks
@landonreed landonreed changed the title Modify OtpDispatcher#sendOtpRequest to throw exception instead of returning null Review Utils to ensure they are throwing exceptions and not failing silently/returning null Aug 4, 2020
@landonreed landonreed added the bug Something isn't working label Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@landonreed