Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme switching #93

Open
Brocman opened this issue Jan 27, 2021 · 4 comments · May be fixed by #116
Open

Theme switching #93

Brocman opened this issue Jan 27, 2021 · 4 comments · May be fixed by #116

Comments

@Brocman
Copy link

Brocman commented Jan 27, 2021

Please implement automatic theme switching when night mode macOS.

@dee-me-tree-or-love
Copy link

This is a nice idea, I had the same feeling as @Brocman. @ibillingsley, I'm not sure I will get the time for this, but I might give it a try in the coming time. Are you currently accepting PRs?

@ibillingsley
Copy link
Owner

I'm not currently accepting PRs because I am planning a rewrite for manifest V3 once it becomes mandatory.

It would be simple enough to change the default theme based on light/dark mode, but to properly support switching we would need to save 2 separate theme configs, since they are customizable.

Also requested in #103

@astrocaat
Copy link

hey @ibillingsley, do you have any updates on this now that you took care of manifest V3?

@dee-me-tree-or-love
Copy link

dee-me-tree-or-love commented Nov 24, 2023

@ibillingsley @astrocaat @Brocman, I've started making a fork and got some basic solution running.
I'll open a draft PR soon and hope to return to it sometime next week as I find the time :)
Hope that's still interesting?

Here's the first impression:
screen-recording-theme-switching

Suggestions and improvements are of course welcome, I'll ping you in the draft PR soon too.
✌️

Note

UPDATE: here's the PR: #116 will be grateful for the review! :-)

@dee-me-tree-or-love dee-me-tree-or-love linked a pull request Nov 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants