Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI : Research : PCIe Hardware Topology #1475

Closed
1 of 21 tasks
derick-montague opened this issue Dec 12, 2019 · 12 comments
Closed
1 of 21 tasks

GUI : Research : PCIe Hardware Topology #1475

derick-montague opened this issue Dec 12, 2019 · 12 comments
Assignees
Labels
Blocked Indicates an item is blocked. Used to be able to filter blocked stories. GUI Catch all tag for GUI stories Milestone Tgt Overrides Epic Milestone UI Design Indicates the GUI story is for Design UI FED Indicates a GUI Front End Development story UI Research Indicates the GUI story is a UI Design Research/Discovery story
Milestone

Comments

@derick-montague
Copy link
Contributor

derick-montague commented Dec 12, 2019

SMEs

BMC: @bradbishop (working on redfish mockup), Link properties @sampmisr , VPD @santoshpuranik , LEDs @vishwabmc
PHYP: Justin King, Adam Stallman, Jessee Arroyo
RAS: Justin Thaler

Research and Design

Use Case

As a PE/Admin/SSR, I need to troubleshoot the connection problems so that I can fix issues with cabling and connectivity between servers and expansion drawers.

InVision Prototype

https://ibm.invisionapp.com/d/main#/console/15347903/320017936/preview

Design Issue (phosphor-webui)

openbmc/webui-vue#66

References/Resources

FED

UX Flow / Interaction Requirements

To Do

  • Follow up with internal users regarding Redfish language vs ASMI language
  • Follow up with Maury on timeline
  • Document for Knowledge Center discussion

  • Refresh date and time: The time stamp reflects the date and time of the last time when the entire table was refreshed. For example, if on using Reset Link function, entire table gets refreshed, then the time stamp needs to be updated.
  • Expansion row layout: If possible, use 2 separate layouts: one for primary links which don't have parent ID (e.g. Link 21) and other for secondary links which have parent ID (e.g. Link 337). Otherwise, use layout shown for Link 21.
  • Identify LEDs: This will show Location LED toggles only for the locations associated directly with a link. See this for primary link and this for secondary link. If layout cannot be dynamic, then use Link 21's layout.
  • ID and Parent ID: Need to be sortable.
  • Default sorting (if possible): By ID. However, secondary links with parent ID should follow right after the corresponding parent link (e.g. in the prototype, links 337 to 342 should come after 21.
  • Link Status: Need to be filterable. Show warning icon for 'Degraded' and 'Failed' status only. No other icons needed.
  • Reset link: Takes around 10 seconds to finish, which is why we added a info toast with a time stamp.

cURL Commands and Redfish Response

This will be based on the Chassis schema (refer Hardware Inventory story)

  • Add Redfish response
  • Add cURL commands

Notes

UI Checklist

Browser Tests (Chrome, Firefox, Safari (Mac), Edge (Windows))

  • Tested responsive layout on supported viewport sizes
  • Verified functionality works as expected, e.g. success and failure use cases
  • Resolved any JavaScript errors thrown to the console

Accessibility Tests

Test Hooks

  • Verify need for data-test-id hooks with test team
@derick-montague derick-montague added GUI Catch all tag for GUI stories UI Design Indicates the GUI story is for Design labels Dec 12, 2019
@derick-montague derick-montague added this to the A.1.203 milestone Dec 12, 2019
@rfrandse rfrandse modified the milestones: A.1.203, A.1.211 Dec 18, 2019
@rfrandse rfrandse modified the milestones: A.1.211, A.1.212 Jul 16, 2020
@derick-montague derick-montague modified the milestones: A.1.212, A.1.204 Sep 22, 2020
@rfrandse rfrandse modified the milestones: A.1.204, A.1.211 Oct 29, 2020
@derick-montague derick-montague changed the title GUI : Design : PCIe Hardware Topology GUI : Research : PCIe Hardware Topology Nov 18, 2020
@derick-montague derick-montague added Milestone Tgt Overrides Epic Milestone UI Research Indicates the GUI story is a UI Design Research/Discovery story and removed UI Design Indicates the GUI story is for Design labels Nov 18, 2020
@derick-montague
Copy link
Contributor Author

This seems like a page that would utilize a log service. I have set the Epic to tbd until it's determined during the research of this feature.

@derick-montague
Copy link
Contributor Author

derick-montague commented Jan 12, 2021

Screen Captures

image

image

@nicoleconser
Copy link
Contributor

Definition of PCIe

PCIe slots allow your motherboard to connect with your PC’s most critical components and provide key functionality. PCIe is short for peripheral component interconnect express and it’s primarily used as a standardized interface for motherboard components including graphics, memory, and storage. A PCIe or PCI express slot is the point of connection between your PC’s “peripheral components” and the motherboard. The term “PCIe card” and “expansion card” simply refers to hardware, like graphics cards, CPUs, solid-state drives (SSDs), or HDDs, you may add to your device through PCIe slots, making both catch-all terms for a variety of components.

@ParishrutB
Copy link

For link properties and VPD

Comments from @santoshpuranik
There is a lot to be figured out for Link properties and PCIe VPD here:

  • Where does the data come from? Most of this information has to be sent to us by PHYP
  • How is the data going to be represented on BMC's D-Bus model?
  • The Redfish API to represent this data and the relations.

@sampmisr (SME for link properties) also communicated that is is a complex story and need to go though a few rounds of discussions.

Have requested for myself and @priyanka-pillai97 to be included in the meeting next week.

For LEDs
Email from Ravindra S Rao stating "the MEX LED support is targeted for 9/30."

@derick-montague
Copy link
Contributor Author

Today's BMC leadership meeting discussed this. @santoshpuranik and @sampmisr will be setting up time with PHYP team. I have asked that @ParishrutB and @priyanka-pillai97 be included. There is quite a bit of backend that needs to be discussed and planned.

@ParishrutB ParishrutB added the UI Design Indicates the GUI story is for Design label Jun 25, 2021
@derick-montague derick-montague added UI FED Indicates a GUI Front End Development story Blocked Indicates an item is blocked. Used to be able to filter blocked stories. labels Jun 28, 2021
@derick-montague
Copy link
Contributor Author

Design ready, Redfish API and backend work is not ready. Blocked until backend is ready.

@ParishrutB
Copy link

Added dependencies. @santoshpuranik says discussions are still going on and so there may be more to it.

@derick-montague
Copy link
Contributor Author

This was reviewed in the Design Exchange meeting. There is a list of key takeaways and to dos in Box.

Summary

  • There is still work required to meet the user needs
  • There are backend design discussions happening now
  • It is expected that the design can be fully implemented with change mostly to naming coming from the Redfish API terminology and standards.
    • These need to be discussed with the ID and support teams.

@derick-montague derick-montague modified the milestones: A.1.212.6, A.1.214 Aug 5, 2021
@derick-montague
Copy link
Contributor Author

Milestone update based on conversation with Maury. Brad Bishop is the BMC SME for this feature.

@derick-montague derick-montague modified the milestones: A.1.214, 214.12 Aug 13, 2021
@derick-montague
Copy link
Contributor Author

derick-montague commented Aug 23, 2021

Further conversation from the design exchange meeting can be found on box

Summary

  • Port locations are called upstream and downstream in Redfish. May not be understood by support team and would need documentation in the Knowledge Center
  • Engineering team not sure how to get ID and Parent IDs (PCIe Bus Numbers) yet
  • Link status we show in design are not what is provided by Redfish
  • Redfish cable schema has information needed for cable support, but is different than ASMI and needs Knowledge Center involvement and support team awareness
  • Unclear when these features will be delivered

@derick-montague
Copy link
Contributor Author

@bradbishop will be doing the work on the backend and @mzipse suggested today in a GUI roadmap sync meeting with @gtmills and @dixsie that a Redfish mock might be provided for the GUI to develop with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Indicates an item is blocked. Used to be able to filter blocked stories. GUI Catch all tag for GUI stories Milestone Tgt Overrides Epic Milestone UI Design Indicates the GUI story is for Design UI FED Indicates a GUI Front End Development story UI Research Indicates the GUI story is a UI Design Research/Discovery story
Projects
None yet
Development

No branches or pull requests

7 participants