Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all std::filesystem::exists calls to noexcept overload #521

Open
souvik1914581 opened this issue Dec 9, 2024 · 0 comments
Open
Assignees

Comments

@souvik1914581
Copy link

souvik1914581 commented Dec 9, 2024

We are using an overload of std:: filesystem :: exists()
which can throw exception in a lot of places (please see screenshot).

We are also using an overload of std:: filesystem :: exists()
which does not throw any exception (noexcept version).

We should change all calls to std::filesystem::exists to the noexcept overload for consistency and for more exception safety.
Screenshot 2024-12-09 at 10 44 55 AM

Refer : https://en.cppreference.com/w/cpp/filesystem/exists

@souvik1914581 souvik1914581 self-assigned this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant