Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with Member Level Incrementation in member.entity.js #138

Open
hitchhooker opened this issue Dec 5, 2023 · 1 comment · May be fixed by #140
Open

Issue with Member Level Incrementation in member.entity.js #138

hitchhooker opened this issue Dec 5, 2023 · 1 comment · May be fixed by #140

Comments

@hitchhooker
Copy link

It appears that there is a logic issue in the member.entity.js file, specifically at the following line:
https://github.com/ibp-network/ibp-monitor/blob/59631c7ff3667f4413e14670f5df1e771b5a2476/domain/member.entity.js#L57C49

The current code seems to incorrectly increment the member level by +1, which results in monitoring for instances that are not yet running.

image

What is the reasoning here for increment? Wouldn't it be making more sense to use members.json as source truth?
@hitchhooker
Copy link
Author

@pandres95 was there any reasoning for this increment if I look to fix it now over the weekend?

@pandres95 pandres95 linked a pull request Dec 11, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing invalid membershipLevelId calculation for MemberEntity instances pandres95/ibp-monitor
1 participant
@hitchhooker