Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Build Telemetry into plugin for protoc and slicec #4016

Open
ReeceHumphreys opened this issue Jul 5, 2024 · 1 comment
Open

Refactor Build Telemetry into plugin for protoc and slicec #4016

ReeceHumphreys opened this issue Jul 5, 2024 · 1 comment

Comments

@ReeceHumphreys
Copy link
Contributor

Currently, as suggested by @pepone the BuildTelemetry works via a shared custom build task that gets called by the IceRpc.Slice.Tools and IceRpc.Protobuf.Tools. I think this approach is good for now as it is simple and does the job. However in the future, we should refactor this logic into a protoc plugin or slicec plugin.

@ReeceHumphreys
Copy link
Contributor Author

Somewhat related, but could be split into a different issue, is @bernardnormier suggested an intermediate refactor before this too where we would split the task into a separate protobuf task and slicec task and have the build telemetry client logic live in these tasks rather than being a separate executable that gets invoked via the task.

I think given the eventual shift to a plugin this intermediate refactor is not really necessary.

@bernardnormier bernardnormier added this to the Future milestone Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants