Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit client error when server aborts connection due to MaxConnections (ice protocol) #4031

Open
bernardnormier opened this issue Aug 26, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@bernardnormier
Copy link
Member

bernardnormier commented Aug 26, 2024

When an ice-protocol server rejects a new connection because MaxConnections is reached, it aborts the transport connection:

_transportConnection!.Dispose();

This abort is in turn received by the client as an IceRpcError.ConnectionAborted (fine) or uncategorized error (IceRpcError.IceRpcError). See #2462.

This behavior is problematic because the ConnectionCache "move to the next server address" requires specific error codes, and IceRpcError.IceRpcError (= uncategorized error) is not among them. See #4027.

@bernardnormier bernardnormier added the bug Something isn't working label Aug 26, 2024
@bernardnormier bernardnormier added this to the Future milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@bernardnormier and others