Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order Remaining should be dynamically calculated #12

Open
nightowl121 opened this issue May 6, 2024 · 1 comment
Open

Order Remaining should be dynamically calculated #12

nightowl121 opened this issue May 6, 2024 · 1 comment
Assignees

Comments

@nightowl121
Copy link

public LiquidityOrder[] getOrders() {
int numberOfOrders = ordersList.size();
LiquidityOrder[] orderData = new LiquidityOrder[numberOfOrders];
for (int i = 0; i < numberOfOrders; i++) {
BigInteger pid = ordersList.get(i);
LiquidityOrder order = orders.get(pid);
order.pid = pid;
orderData[i] = order;
}
return orderData;
}

The remaining field should be calculated dynamically since its dependent on the current block height. We could lose an opportunity to get more lp token since the UI uses the current remaining field.

@pragyanshrestha-ibriz
Copy link

@AntonAndell is this issue still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants