Fix Tally Parser with parser function overloading #180
Labels
code improvement
A feature request that will improve the software and its maintainability, but be invisible to users.
feature request
An issue that improves the user interface.
This is likely dependent on #137.
Background
As part of !98, which was meant increase the test coverage for 0.2.0alpha prior to a full release. I discovered that a lot of the code in
mcnpy/input_parser/tally_parser.py
wasn't being ran. Specifically the syntax rules for handlingTR3 (1 2 3)
. This took forever to figure out, and was very much black magic.The issue was that all parser objects had the same function object for
number_sequence
, andCellParser
was redefining this to handlefill
statements.I tried to fix this in the branch overload_dict (see 3328c0b, and d57793b).
For the time being, I am thinking of reverting my changes to the parsing rules for the time being because:
The text was updated successfully, but these errors were encountered: