Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tally Parser with parser function overloading #180

Open
MicahGale opened this issue Sep 12, 2023 · 7 comments
Open

Fix Tally Parser with parser function overloading #180

MicahGale opened this issue Sep 12, 2023 · 7 comments
Labels
code improvement A feature request that will improve the software and its maintainability, but be invisible to users. feature request An issue that improves the user interface.

Comments

@MicahGale
Copy link
Collaborator

This is likely dependent on #137.

Background

As part of !98, which was meant increase the test coverage for 0.2.0alpha prior to a full release. I discovered that a lot of the code in mcnpy/input_parser/tally_parser.py wasn't being ran. Specifically the syntax rules for handling TR3 (1 2 3). This took forever to figure out, and was very much black magic.

The issue was that all parser objects had the same function object for number_sequence, and CellParser was redefining this to handle fill statements.

I tried to fix this in the branch overload_dict (see 3328c0b, and d57793b).

For the time being, I am thinking of reverting my changes to the parsing rules for the time being because:

  1. Test cases weren't failing
  2. Tallies aren't being worked with so the tree doesn't need to be pretty
  3. This is going to need Find parsing bottle necks. #137, which is turning out to be pretty complicated.
@MicahGale
Copy link
Collaborator Author

mentioned in commit 11357498c80cc4efbe23aa0495e885a1b82aa7cd

@MicahGale
Copy link
Collaborator Author

mentioned in commit a874421900e7e2e78d2af094058b23cf8724db8e

@MicahGale
Copy link
Collaborator Author

mentioned in commit d1009c00d44ac9ec97604cc0a9f3a71afc2372cc

@MicahGale
Copy link
Collaborator Author

mentioned in commit fef598518e5c1e1f8eb9c2c3f2371ef84eba36c5

@MicahGale
Copy link
Collaborator Author

mentioned in commit 3b58558e00c4ece922c1ab18b75c8d649ab985f4

@MicahGale
Copy link
Collaborator Author

mentioned in commit d1977a9d8b19949d5059cc80fc41b3508a0dbd8b

@MicahGale
Copy link
Collaborator Author

mentioned in commit 607707b

@MicahGale MicahGale removed this from the Release-1.0.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code improvement A feature request that will improve the software and its maintainability, but be invisible to users. feature request An issue that improves the user interface.
Projects
None yet
Development

No branches or pull requests

1 participant