-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix O(N^2) operation in Material #510
Labels
code improvement
A feature request that will improve the software and its maintainability, but be invisible to users.
performance 🐌
Issues related to speed and memory
Comments
MicahGale
added
the
code improvement
A feature request that will improve the software and its maintainability, but be invisible to users.
label
Aug 26, 2024
See also: #137 (comment) |
Some new profiling data:
So this is very very inefficient. I think if this were fixed we could open the benchmark case in ~20 seconds? |
MicahGale
changed the title
Fix O(N^2) operation in Material
Fix O(N<sup>2</sup>) operation in Material
Aug 28, 2024
MicahGale
changed the title
Fix O(N<sup>2</sup>) operation in Material
Fix O(N^2) operation in Material
Aug 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code improvement
A feature request that will improve the software and its maintainability, but be invisible to users.
performance 🐌
Issues related to speed and memory
MCNP_Probelm.update_pointers
there is afor data_input in self.data_inputs
loop effective.Material.update_pointers
which has:for data_input in data_inputs:
loop.M
toMT
. If we did vice versaMT
could use hashing to move to an O(1) operation.Material.__hash__
getting called so much?NumberedObjectCollection
is meant to hash on numbers and not objects I thought. There is something weird going on here that needs further investigation.The text was updated successfully, but these errors were encountered: