Warn people when MOOSE submodule is out of date

[andrsd]

This is what we have in RELAP-7's Makefile:

CURRENT_DIR        := $(shell pwd)
APP_DIR            ?= $(CURRENT_DIR)

# moose submodule status
moose_status := $(shell git -C $(APP_DIR) submodule status 2>/dev/null | grep moose | cut -c1)
ifneq (,$(findstring +,$(moose_status)))
  ifneq ($(origin APP_DIR),environment)
    moose_status_msg = "WARNING: Your MOOSE submodule is out of date.\n"
  endif
endif

all:: moose_submodule_status

moose_submodule_status:
    @if [ x$(moose_status_msg) != "x" ]; then echo $(moose_status_msg); fi

When people's MOOSE submodule is out of date, the first message they see is the WARNING line.

This seemed to be working for us for some time, so should we add this into stork? There might be some corner cases with this that I do not see....

[friedmud]

I definitely like this idea... but can we make it an error instead of a warning? I'd love to do it for MOOSE / libMesh too...

[andrsd]

We can. I have it as warning, because sometimes I run with newer MOOSE than the submodule links and in that case, it would stop the build...

[permcody]

We already have a Warning for libMesh being out of date too. It's in the
build libmesh script.

On Tue, May 24, 2016 at 4:07 PM David Andrs [email protected]
wrote:

We can. I have it as warning, because sometimes I run with newer MOOSE
than the submodule links and in that case, it would stop the build...

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#34 (comment)

[andrsd]

I was looking for the warning, but I could not find it. I know, I based my code on it, so it has to be somewhere. Also, I fixed a small problem where we were reporting module not up to date, while it was ok. The line with git status was missing the last piece cut -c1.

One more thing, why would build libmesh script report libmesh submodule not up to date? It should be reported when we execute make, right?

[permcody]

David you're right. It's in moose.mk.

On Wed, May 25, 2016 at 12:23 PM David Andrs [email protected]
wrote:

I was looking for the warning, but I could not find it. I know, I based my
code on it, so it has to be somewhere. Also, I fixed a small problem where
we were reporting module not up to date, while it was ok. The line with git
status was missing the last piece cut -c1.

One more thing, why would build libmesh script report libmesh submodule
not up to date? It should be reported when we execute make, right?

—
You are receiving this because you commented.

Reply to this email directly or view it on GitHub
#34 (comment)

[andrsd]

Thanks @permcody. I was grepping for "git submodule" and did not find it, becuase of that -C flag in between git and submodule ;-), I will have a small patch that improves the check. The problem we saw in RELAP was, that git submodule would report something like this:

 <sha1-hash> moose (C++03_final)

so our findstring would find the + coming from the tag, while we need to look at the first character.