Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes with titles should have an id for the heading #42

Open
bernhold opened this issue Nov 1, 2023 · 2 comments
Open

Includes with titles should have an id for the heading #42

bernhold opened this issue Nov 1, 2023 · 2 comments
Labels
enhancement New feature or request priority: low

Comments

@bernhold
Copy link
Contributor

bernhold commented Nov 1, 2023

We can generate an id for each heading by slugifying the text of the heading. I've done this in _includes/_events/events-list.html. We should do it in others.

@bernhold bernhold added the enhancement New feature or request label Nov 1, 2023
@bernhold
Copy link
Contributor Author

bernhold commented Feb 3, 2024

A good default would be to slugify the header content. Still useful to accept an argument to override it.

@bernhold
Copy link
Contributor Author

While I still think this is a good idea, there are about 30 includes that have a title or similar parameter that results in an HTML heading. Many already accept an additional parameter for the id, but don't have any default. It would be a lot of work to change and test all of these. And I'm not sure it is worth it. So I now consider this lower priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: low
Projects
None yet
Development

No branches or pull requests

1 participant