Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Plant Environment Ontology pattern #152

Open
cthoyt opened this issue Mar 16, 2021 · 4 comments
Open

Issue with Plant Environment Ontology pattern #152

cthoyt opened this issue Mar 16, 2021 · 4 comments
Labels

Comments

@cthoyt
Copy link

cthoyt commented Mar 16, 2021

This issue references the Plant Environment Ontology, which is registered in Identifiers.org at https://registry.identifiers.org/registry/eo

Actual: ^(P)?EO\:\d{7}$
Expected: ^EO:\d{7}$

Issues:

  • the optional P does not work
  • there's a redundant escape for the colon
  • EO isn't the same as the prefix, so how does namespaceEmbeddedinLUI help a user generate a valid CURIE?
@renatocjn
Copy link
Member

Which namespace is this referring to?

@cthoyt cthoyt changed the title Issue with PECO pattern Issue with Plant Environment Ontology pattern Jan 5, 2023
@cthoyt
Copy link
Author

cthoyt commented Jan 5, 2023

https://registry.identifiers.org/registry/eo, sorry for not being more specific earlier.

@renatocjn
Copy link
Member

Hello,
Thanks for referencing the namespace 👍

This one is a bit complicated.

First, the frontend is messed up like in identifiers-org/cloud-hq-web-frontend#48. I need to investigate it but it may be related to the namespaceEmbeddedinLUI flag.

A compact ID such as EO:0007404 works because the resolver transforms everything into lowercase which is why it correctly resolves because it is registered as eo in the backend.

But a PEO prefix would not be found because the namespace is registered as eo. I don't have a PEO example. It may have been a legacy namespace brought from the previous version of identifiers.org.

@renatocjn
Copy link
Member

Seems like both EO and PEO were replaced with PECO.
I opened an issue Planteome/plant-experimental-conditions-ontology#133 with them to see if they will provide some clarification. If that is the case, I will depreciate the namespace and create the PECO namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants