Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing tensorflow version of CausalDotProduct #73

Open
JamesDeAntonis opened this issue Mar 16, 2021 · 1 comment
Open

Implementing tensorflow version of CausalDotProduct #73

JamesDeAntonis opened this issue Mar 16, 2021 · 1 comment

Comments

@JamesDeAntonis
Copy link

May we create a tensorflow version of CausalDotProduct? This is necessary for the transformers implementation of Performers, which implements for both pytorch and tf.

If you don't want this done, we would instead copy-and-paste the code into transformers, then make the necessary changes to tensorflow. While that is fine, I think it's cleaner to do it all in this repo.

@angeloskath
Copy link
Collaborator

Hi James,

Sorry for the late reply. I understand why you would want to keep it in this repo, it is all updated together and tested together.

However, how would you go about integrating it? Where would the code reside? In the main fast_transformers package?

Let me know your thoughts, I am totally open to suggestions.

Cheers,
Angelos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants