Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only posts first photo from a multiple photo post #17

Open
nuggit opened this issue Jun 30, 2019 · 5 comments
Open

Only posts first photo from a multiple photo post #17

nuggit opened this issue Jun 30, 2019 · 5 comments

Comments

@nuggit
Copy link

nuggit commented Jun 30, 2019

While trying to do this:

Posting a "stack" of photos from Instagram via https://ownyourgram.com/photos

I encountered this error:

  • it only posts the first photo/video screenshot

Some other notes:

Give us some context:

  • version.known: version = '0.12.8' build = '2019062801'
  • I am using mysql
  • Diagnostics page just has this warning: You appear to be running directly from a git checkout [...]
@cleverdevil
Copy link

So, the issue is in our Micropub implementation right here:

https://github.com/idno/known/blob/master/IdnoPlugins/IndiePub/Pages/MicroPub/Endpoint.php#L178

Known's Photo plugin now happily supports multi-photo posts, so this could (and should!) absolutely be supported.

@cleverdevil
Copy link

Also see Photo plugin implementation:

https://github.com/idno/known/blob/master/IdnoPlugins/Photo/Photo.php#L137

@mapkyca
Copy link
Member

mapkyca commented Jul 1, 2019

As remarked, the micro pub stuff needs a lot of love

@mapkyca mapkyca transferred this issue from idno/known Aug 11, 2019
@cdn
Copy link
Contributor

cdn commented Nov 10, 2019

You can add a pair of square brackets in the uploadFromUrl() function :
https://github.com/cdn/indiepub/blob/master/Pages/MicroPub/Endpoint.php#L660

@cdn
Copy link
Contributor

cdn commented Nov 11, 2019

You can add a pair of square brackets in the uploadFromUrl() function :
https://github.com/cdn/indiepub/blob/master/Pages/MicroPub/Endpoint.php#L660

That isn't the whole fix, since the OwnYourGram payload is JSON, that code @cleverdevil referenced #17 (comment) would need removing

Plus uploadFromUrl() needs a foreach() as my fork's copy now has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants