Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Media into Audio and Video plugins #1

Open
benwerd opened this issue Sep 6, 2018 · 3 comments
Open

Split Media into Audio and Video plugins #1

benwerd opened this issue Sep 6, 2018 · 3 comments

Comments

@benwerd
Copy link
Member

benwerd commented Sep 6, 2018

Video is, of course, much much much harder to implement.

But these two media types have very different needs and should be two different plugins.

@mapkyca
Copy link
Member

mapkyca commented Sep 6, 2018

Yes, probably smart.

For video it might be worth merging in the transcoding work I did elsewhere (https://github.com/mapkyca/KnownVideoTranscode)

@benwerd
Copy link
Member Author

benwerd commented Sep 6, 2018

I'd be very against merging use of ffmpeg (etc) into core; the idea of supporting that on most systems gives me the shivers. I suspect this is a case where a third-party hosted service or an external plugin could do the gruntwork, and then post into the Known stream via integration or webhook.

@mapkyca
Copy link
Member

mapkyca commented Sep 7, 2018

Fair point. My understanding of this ticket was that we were talking about spinning out Video into its separate third party plugin (rather than having it as a legacy feature / easter egg in Audio). Since video is still something that requires transcoding (although browser support is getting better) it makes sense to bundle ffmpeg into that video plugin and make that "complete", but to not necessarily support it ourselves.

@mapkyca mapkyca transferred this issue from idno/known Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants