Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor EMs in RuntimeConfig. #1181

Closed
staudtMarius opened this issue Feb 14, 2025 · 0 comments · Fixed by #1182
Closed

Refactor EMs in RuntimeConfig. #1181

staudtMarius opened this issue Feb 14, 2025 · 0 comments · Fixed by #1182
Assignees
@staudtMarius
Labels
code quality Code readability or efficiency is improved config Issues related to the configuration of simulation runs

Comments

@staudtMarius
Copy link
Member

staudtMarius commented Feb 14, 2025 •
edited
Loading

EMs should not be part of the participant runtime configuration.

See @sebastian-peter in #1173 (comment)
@staudtMarius staudtMarius self-assigned this Feb 14, 2025
@staudtMarius staudtMarius added code quality Code readability or efficiency is improved config Issues related to the configuration of simulation runs labels Feb 14, 2025
@staudtMarius staudtMarius mentioned this issue Feb 14, 2025
Merged
staudtMarius added a commit that referenced this issue Feb 18, 2025
@staudtMarius
Merge branch 'dev' into ms/#1181-refactor-ems-in-runtimeConfig
3dea2d5
sebastian-peter added a commit that referenced this issue Feb 24, 2025
@sebastian-peter
Merge branch 'dev' into ms/#1181-refactor-ems-in-runtimeConfig
3536e24 
# Conflicts:
#	CHANGELOG.md
sebastian-peter added a commit that referenced this issue Feb 24, 2025
@sebastian-peter
Merge pull request #1182 from ie3-institute/ms/#1181-refactor-ems-in-…
1e2bda7 
…runtimeConfig

Refactor `EmRuntimeConfig`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staudtMarius staudtMarius

Labels
code quality Code readability or efficiency is improved config Issues related to the configuration of simulation runs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor EmRuntimeConfig ie3-institute/simona
1 participant
@staudtMarius