Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move static methods in PvModel class to the companion object #1217

Open
sebastian-peter opened this issue Feb 21, 2025 · 0 comments
Open

Move static methods in PvModel class to the companion object #1217

sebastian-peter opened this issue Feb 21, 2025 · 0 comments
Labels
code quality Code readability or efficiency is improved

Comments

@sebastian-peter
Copy link
Member

Since these methods should not depend on the fields of the class, but rather get all the relevant data via the method parameters, they can also be static (thus in the object) and therefore be safer against future mishaps.

@sebastian-peter sebastian-peter added the code quality Code readability or efficiency is improved label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code readability or efficiency is improved
Projects
None yet
Development

No branches or pull requests

1 participant