Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in time formatting #9

Open
iqfareez opened this issue Jul 9, 2023 · 0 comments
Open

Inconsistency in time formatting #9

iqfareez opened this issue Jul 9, 2023 · 0 comments

Comments

@iqfareez
Copy link
Member

iqfareez commented Jul 9, 2023

This is umbrella issue for all issues related to time formatting in Albiruni Portal.

Issue 1: Inconsistent in AM/PM convention

Take a look at this:
image
Okay, it is understandable, the AM belongs to both of the starting and ending time. Tthe slot is in the morning 8.30 AM - 9.50 AM

Now look at this:
image

The slot start at 11.30 AM - 12.50 PM. So, it is assumed that the AM in the time above is belongs to the start time only (because no one will have class at 12.50 AM isn't it). Fair enough.

This is more challenging, but still easy to interpret:
image

Since the AM belongs to the starting time. We can interpret the time is 8.00 AM - 5.00 PM.

TODO: The parser still parse to incorrect result, see this https://github.com/iqfareez/albiruni_fetcher/pull/6/files#diff-6e8304a4d23b7da033076a5082662c2c00d18322eb67ebfbea3f19237fe09b28. Need check.

But.. What about this??

image

Taking our assumption that the AM/PM belongs to the start time, then this time with result to starting time 11 PM - 1 AM?? Ain't no way. So, we cannot just assume the AM/PM belongs to start time. This is where the timing convention is fcked up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant