You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is umbrella issue for all issues related to time formatting in Albiruni Portal.
Issue 1: Inconsistent in AM/PM convention
Take a look at this:
Okay, it is understandable, the AM belongs to both of the starting and ending time. Tthe slot is in the morning 8.30 AM - 9.50 AM
Now look at this:
The slot start at 11.30 AM - 12.50 PM. So, it is assumed that the AM in the time above is belongs to the start time only (because no one will have class at 12.50 AM isn't it). Fair enough.
This is more challenging, but still easy to interpret:
Since the AM belongs to the starting time. We can interpret the time is 8.00 AM - 5.00 PM.
Taking our assumption that the AM/PM belongs to the start time, then this time with result to starting time 11 PM - 1 AM?? Ain't no way. So, we cannot just assume the AM/PM belongs to start time. This is where the timing convention is fcked up.
The text was updated successfully, but these errors were encountered:
This is umbrella issue for all issues related to time formatting in Albiruni Portal.
Issue 1: Inconsistent in AM/PM convention
Take a look at this:
Okay, it is understandable, the AM belongs to both of the starting and ending time. Tthe slot is in the morning
8.30 AM - 9.50 AM
Now look at this:
The slot start at
11.30 AM - 12.50
PM. So, it is assumed that the AM in the time above is belongs to the start time only (because no one will have class at 12.50 AM isn't it). Fair enough.This is more challenging, but still easy to interpret:
Since the AM belongs to the starting time. We can interpret the time is
8.00 AM - 5.00 PM
.TODO: The parser still parse to incorrect result, see this https://github.com/iqfareez/albiruni_fetcher/pull/6/files#diff-6e8304a4d23b7da033076a5082662c2c00d18322eb67ebfbea3f19237fe09b28. Need check.
But.. What about this??
Taking our assumption that the AM/PM belongs to the start time, then this time with result to starting time
11 PM - 1 AM
?? Ain't no way. So, we cannot just assume the AM/PM belongs to start time. This is where the timing convention is fcked up.The text was updated successfully, but these errors were encountered: