Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥯 Not all subjects are fetched #10

Open
iqfareez opened this issue Aug 6, 2023 · 0 comments
Open

🥯 Not all subjects are fetched #10

iqfareez opened this issue Aug 6, 2023 · 0 comments

Comments

@iqfareez
Copy link
Member

iqfareez commented Aug 6, 2023

The issues

Looking at the fetcher action, for example, this one: #9 that fetches Session 2023/2024, Semester 1, the ENGIN kulliyyah appear to fetched way less than usual.

image

The equivalent albiruni data: https://albiruni.iium.edu.my/myapps/StudentOnline/schedule1.php?action=view&view=50&kuly=ENGIN&tot_pages=13&ctype=%3C&course=&sem=1&ses=2023/2024 had a lot of subjects available.

image

One page shows about 50 subjects, so, doing the math, ENGIN should have about 650-ish subjects available.

Discussion

This fetcher script depends on albiruni package (GitHub), which has its known issue iiumschedule/albiruni#7, where the time formatting is unusual that causes albiruni package can't parse it correctly.

The error is happening on one page only (as shown in video below), but the fetcher stops scraping the next page.

iiumschedule_format_error.webm

Proposal

Change the script to ignore the error and just proceed to next page available. This way, we only lost one page worth of subject instead of many pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant