Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachments not working #8

Open
brogol opened this issue Jan 7, 2021 · 2 comments
Open

Attachments not working #8

brogol opened this issue Jan 7, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@brogol
Copy link

brogol commented Jan 7, 2021

Hello there,
It seems attachments property is added at the wrong place in the msg object. I had to change line 82 to make it work. Not confortable enough to make a clean PR but this dirty modification seems to do the trick:
if (attachments) msg.Messages[0].Attachments = attachments;

@ScottAgirs
Copy link
Contributor

Hey @brogol , thanks for opening an issue, would you mind submitting a PR, I'll be happy to look through and give you pointers if need be.

Sorry for the delay, and if you'll submit we'll add this with the next minor version of Strapi.

@ScottAgirs ScottAgirs added the bug Something isn't working label Feb 23, 2021
@SalahAdDin
Copy link

SalahAdDin commented Apr 15, 2022

It seems neither this package nor postmark one are being maintained anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants