From 3491f326b69a2a9941c562df238144905708f823 Mon Sep 17 00:00:00 2001 From: ikeman32 Date: Wed, 2 Feb 2022 18:09:35 -0800 Subject: [PATCH] breaking changes --- README.md | 11 +++++++++++ package.json | 2 +- template.json | 1 - template/src/App.js | 1 - template/src/App.scss | 0 template/src/components/index.js | 6 +++++- template/src/index.js | 1 - template/src/index.scss | 18 ------------------ template/src/routes/Routes.js | 2 +- 9 files changed, 18 insertions(+), 24 deletions(-) delete mode 100644 template/src/App.scss delete mode 100644 template/src/index.scss diff --git a/README.md b/README.md index 6614f21..e0ac1dc 100644 --- a/README.md +++ b/README.md @@ -6,6 +6,17 @@ react-router-dom 6.1.1. ## How To Install +## Breaking changes +There are some issues with some of the node pmodules requiring vulnerable versions of certain modules and you may encounter a similar error as this: + +Compiled with problems: + +ERROR in ./node_modules/history/index.js + +and a stack trace through multiple files ending up with webpack compiling with an error. +Right now the workaround is to run npm audit fix --force to install the breaking changes and vulnerable modules. + + requires create-react-app v5.0.0 to force your system to use create-react-app v5 append '@5.0.0' to the create-react-app diff --git a/package.json b/package.json index 5527318..5818f5c 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "cra-template-duke", - "version": "1.2.2", + "version": "1.2.3", "description": "Create React App Template", "main": "template.json", "scripts": { diff --git a/template.json b/template.json index 4c6b16c..b9f20c4 100644 --- a/template.json +++ b/template.json @@ -12,7 +12,6 @@ "react-is": "^17.0.2", "react-router-dom": "^6.1.1", "react-scripts": "^5.0.0", - "sass": "^1.45.0", "styled-components": "^5.3.3" } } diff --git a/template/src/App.js b/template/src/App.js index 69edfdd..a0f6713 100644 --- a/template/src/App.js +++ b/template/src/App.js @@ -1,7 +1,6 @@ import * as React from 'react'; import MyRoutes from './components/routes/Routes';//Import routes import { Header, StickyFooter, sections, title } from "./components/index"; -import './App.scss'; function App() { return ( diff --git a/template/src/App.scss b/template/src/App.scss deleted file mode 100644 index e69de29..0000000 diff --git a/template/src/components/index.js b/template/src/components/index.js index c964be4..6285d9f 100644 --- a/template/src/components/index.js +++ b/template/src/components/index.js @@ -1,11 +1,15 @@ //Import your custom components here import Header from './header/Header'; import StickyFooter from './footer/StickeyFooter'; +import { sections, title } from './header/HeaderProps'; //Then export them here export { Header, - StickyFooter + StickyFooter, + sections, + title + }; /* diff --git a/template/src/index.js b/template/src/index.js index d19b414..998e21b 100644 --- a/template/src/index.js +++ b/template/src/index.js @@ -1,7 +1,6 @@ import * as React from "react"; import ReactDOM from "react-dom"; import { BrowserRouter as Router } from "react-router-dom"; -import "./index.scss"; import App from "./App"; ReactDOM.render( diff --git a/template/src/index.scss b/template/src/index.scss deleted file mode 100644 index fc7442e..0000000 --- a/template/src/index.scss +++ /dev/null @@ -1,18 +0,0 @@ -* { - margin: 0; - -} - -body { - margin: 0; - font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', 'Roboto', 'Oxygen', - 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', - sans-serif; - -webkit-font-smoothing: antialiased; - -moz-osx-font-smoothing: grayscale; -} - -code { - font-family: source-code-pro, Menlo, Monaco, Consolas, 'Courier New', - monospace; -} diff --git a/template/src/routes/Routes.js b/template/src/routes/Routes.js index 0cda117..ebdce15 100644 --- a/template/src/routes/Routes.js +++ b/template/src/routes/Routes.js @@ -12,7 +12,7 @@ const MyRoutes = () => { <> } /> - } /> + } /> {/* }/> */}