Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svelte-preprocess 5 is available #362

Open
canadaduane opened this issue Dec 30, 2022 · 3 comments
Open

svelte-preprocess 5 is available #362

canadaduane opened this issue Dec 30, 2022 · 3 comments

Comments

@canadaduane
Copy link

I'm new and was following the directions from the readme to get started. I believe svelte-preprocess version 4 is required at the present time, but "latest" now defaults to 5.0. It may be helpful to others to update the readme to something like this:

npm install --save-dev svelte-preprocess@4 sass postcss
# -- or --
yarn add --dev svelte-preprocess@4 sass postcss
# -- or --
pnpm add --save-dev svelte-preprocess@4 sass postcss
@aabounegm
Copy link
Collaborator

Did you face any problems when installing v5? It seems to me that the breaking changes shouldn't affect us since we recommend installing sass and not node-sass, and while we don't explicitly specify a minimum node version, I doubt anyone who uses Svelte(Kit) has Node.js earlier than v14.

Anyways, after the WIP migration to SvelteKit (particularly, the migration from Sass to CSS), we should hopefully not need any of these dependencies.

@canadaduane
Copy link
Author

It was more of a warning than a problem:

image

@aabounegm
Copy link
Collaborator

Ah, right, this should be harmless. We just need to update the allowed version range in the peer dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants