Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't auto-play next episode #199

Open
nuentes opened this issue Jul 13, 2020 · 46 comments
Open

Doesn't auto-play next episode #199

nuentes opened this issue Jul 13, 2020 · 46 comments
Labels
bug Something isn't working emby Related to Emby add-on

Comments

@nuentes
Copy link

nuentes commented Jul 13, 2020

I've been having a weird issue with UpNext for a while. Hard to say how long, but I believe it goes back several versions. The dialog comes up just fine, and I can click both buttons, and they both work correctly if I manually click them. However, if I do nothing, the video simply ends. In the settings, I definitely have "Default action when nothing selected" correctly set to "Play".

I've tried an uninstall/reinstall of UpNext, and I've also downgraded from 1.1.2 to 1.0.5, and I have the exact same issue with either version. I was previously using the BOX skin, but I'm switching to Arctic Zephyr 2 and seeing the same issue on AZ2. All my media is added via Emby for Kodi. I have also confirmed that I do not have anything selected in the "Play next video automatically" setting for Kodi.

This logfile is from a clean Kodi boot (I still have 1.0.5 at the time of testing). I played an episode of a series. I skipped to the end of the episode and waited for the dialog to come up. For the first test episode, I selected "Watch Now" and the next episode correctly played. For the 2nd episode, I simply did nothing. The dialog came up, and the video player simply closed after the 20 seconds. Relevent part of my kodi logfile: https://paste.kodi.tv/vepepereca.kodi

@dagwieers

This comment has been minimized.

@nuentes
Copy link
Author

nuentes commented Jul 14, 2020

It looks like those commits were merged into master, so I downloaded and manually installed a zip of the master branch, and still had the same issue. I disabled and re-enabled the service just to be sure. I previously still had 1.0.5 installed (with auto-updates disabled) and now it shows 1.1.2 again.

I didn't mention it before, but this is installed on an Android device, if that's relevant.

@dagwieers dagwieers added the bug Something isn't working label Jul 14, 2020
@nuentes
Copy link
Author

nuentes commented Jul 17, 2020

Based on updates in 198, it sounds like this is something that could potentially be resolved by the way an addon handles playback. Would it make sense to report this in the Emby forums?

@im85288
Copy link
Owner

im85288 commented Jul 17, 2020

@nuentes Emby for Kodi has two playback methods. If you selected Direct Paths (which I advise) then the behaviour is just like having your media locally installed in Kodi. The other method would use our addon integration method for showing upnext. It has all worked well in the past but not sure why it's not now. @angelblue05 does not seem to be active on Emby for Kodi so I think you'll have more success pursuing the issue here.

Can you try on a different device to see if we can rule out it being an Android issue?

@nuentes
Copy link
Author

nuentes commented Jul 17, 2020

Direct Paths requires me to change how my media is added in Emby. Right now my media is added via local folder paths. However, in the near future, I hope to move them to NFS or SMB paths, which would allow me to switch to Direct Play.

I currently only have Kodi installed on Android Devices. I'll install it on my laptop to test.

@im85288
Copy link
Owner

im85288 commented Jul 17, 2020

Can you do me a favour and test via Embycon if your not using direct paths. If it works correctly with Embycon we know it's Emby for Kodi that needs fixing.

@nuentes
Copy link
Author

nuentes commented Jul 18, 2020

Identical issue with Embycon.

@GOvEy1nw
Copy link

I have the same issue here.

I've just moved from Plex to Emby and have always used Kodi as the 'client' for either servers. When using Plex Kodi Connect (via it's default Add-on Path method) 'Up Next' worked pretty flawlessly, albeit with a kind of weird delay between episodes where it would pop back to the screen I started playing the episode from and hang there for a second or two, I guess while PKC prepped and loaded the next episode, but it did work all the time.

With Emby for Kodi (again using add-on path method), 'Up Next' rarely works (like it works maybe 5% of the time, but when it does work it goes straight to the next episode with no weird waiting on the selection screen etc. But again it doesn't work most of the time at all.

Also as a side note, I noticed that once when I was watching an episode of Show A, when then next up pop up appeared it was suggesting it was going to play an episode of Show B, even though there were still more episodes of show A to continue watching. So that was weird too.

I haven't tried Direct Path method as I'm aware this will reduce some usability between Kodi and Emby, so I'd prefer to keep with the Add-on path option if at all possible.

If you need any logs from me too, let me know and I'll sort some for you.

Cheers!

@nuentes
Copy link
Author

nuentes commented Jul 23, 2020

once when I was watching an episode of Show A, when then next up pop up appeared it was suggesting it was going to play an episode of Show B, even though there were still more episodes of show A to continue watching. So that was weird too.

Yeah, now that you mention it, I've seen this several times as well. For me, it usually only has come up when Show A had no more episodes.

@GOvEy1nw
Copy link

once when I was watching an episode of Show A, when then next up pop up appeared it was suggesting it was going to play an episode of Show B, even though there were still more episodes of show A to continue watching. So that was weird too.

Yeah, now that you mention it, I've seen this several times as well. For me, it usually only has come up when Show A had no more episodes.

I think that behaviour might make a little more sense, but in my case there were definitely more episodes left, & I had the 'include already watched episodes' option ticked or whatever it's called, so strange that it happened in my case.

@dagwieers
Copy link
Collaborator

once when I was watching an episode of Show A, when then next up pop up appeared it was suggesting it was going to play an episode of Show B, even though there were still more episodes of show A to continue watching. So that was weird too.

This is a bug in the Up Next integration of the add-on. It is best to report this upstream as an issue in order to get this resolved. Up Next only processes what it receives, so in this case it appears to have received the wrong thing?

@im85288
Copy link
Owner

im85288 commented Jul 23, 2020

When I get the chance I'll also test. I used to use EmbyCon all the time and worked with the Dev to make sure everything worked. Recently though I use Emby for Kodi with Direct Paths (and as stated before this method simulates having a native Kodi database..which therefore means it works perfectly).

@dagwieers
Copy link
Collaborator

dagwieers commented Jul 23, 2020

'Up Next' worked pretty flawlessly, albeit with a kind of weird delay between episodes where it would pop back to the screen I started playing the episode from and hang there for a second or two, I guess while PKC prepped and loaded the next episode, but it did work all the time.

This is caused by the delay of triggering the add-on to play the next episode (and the time it takes to start playing). We could tigger it earlier (when we near the end of the video), but risk cutting off the video too soon. We do not know how much time it will take to start the next episode so Kodi simply returns to the calling menu before the next playback is actually started.

Since v1.1.0 we support play_url playback, which makes Up Next perform playing the next episode (so avoids the call to the add-on service). This should help in a more efficient codepath.

In this master branch we add the upcoming episode to the playlist, which should make things smoother when the video finishes.

However we still depend on the time it takes to start the next episode (possibly re-authenticating). If you press "Play next" in the notification pop-up, things will be smoother, because playback is still ongoing until the next episode is started, but when the video ends, Kodi returns to the calling menu (until playback starts) and this does not offer a good user experience.

With Emby for Kodi (again using add-on path method), 'Up Next' rarely works (like it works maybe 5% of the time, but when it does work it goes straight to the next episode with no weird waiting on the selection screen etc. But again it doesn't work most of the time at all.

This requires some troubleshooting to understand what is going on. There is a bug in Kodi related to concurrent busy dialogs in Kodi (possibly fixed in xbmc/xbmc#18104) that could be happening here too.

@nuentes
Copy link
Author

nuentes commented Jul 24, 2020

I just started thinking, and it seems like it's related to what you're discussing above. As I said, clicking "Watch Now" works, but waiting for the auto-playback fails. I know this idea is a bandaid solution, but would it be possible to detect if the filepath looks like an emby path, and if it is, UpNext waits until there is a very tiny increment of video playback remaining (say 0.01s), and then it simply replicates the "Watch Now" action to play the next episode?

@nuentes
Copy link
Author

nuentes commented Jul 26, 2020

I was able to get Direct Play configured today, and can confirm that this resolves the issue.

@im85288
Copy link
Owner

im85288 commented Jul 26, 2020

Thanks for confirming, I know with the addon paths you can use cinema intros..but direct paths is definitely the more robust option. It also assures your server is not transcoding and therefore using up resources.

@GOvEy1nw
Copy link

I don't mind using direct paths in my house, but I also share my library with family and with direct paths I expect it would be much more difficult to do remotely, plus I wouldn't then be able to see when people are watching something etc

@nuentes
Copy link
Author

nuentes commented Jul 26, 2020

I also didn't really know how Direct paths worked until I configured them. Adding direct paths does not limit or change what you currently do, it simply adds another option. So I added the direct paths on the emby server, and configured Kodi to use the direct paths. However, I could have left Kodi the way it was, and it would have still functioned the same. Also, I did notice that Emby still tracked when I was watching something, and I could still see the status in the Dashboard.

@GOvEy1nw
Copy link

So I added the direct paths on the emby server, and configured Kodi to use the direct paths.

Great, ok I'll give it a shot, do you know of a guide anywhere to get it set up? As I'm using an Nvidia Shield and at the minute I've not managed to get Direct Paths working, even though the Shield itself can mount network storage. I assume the issue might be that I've not done anything about 'direct paths' on the emby server end of things. What settings do I have to set/change there?

@im85288
Copy link
Owner

im85288 commented Jul 27, 2020

Either you can edit the Library path or there’s an option in the library section for a network path.

As a rule never create your library pointing at for example the C: of a computer instead use UNC mapping.

For example: 192.168.1.100/tvshows

I know the shield dose Samba sharing so you’ll be able to get it working fairly easily.

@GOvEy1nw
Copy link

Either you can edit the Library path or there’s an option in the library section for a network path.

As a rule never create your library pointing at for example the C: of a computer instead use UNC mapping.

For example: 192.168.1.100/tvshows

I know the shield dose Samba sharing so you’ll be able to get it working fairly easily.

great thanks, I'm working on doing that now. Is there a way to do 'direct paths' for remote users too? Obviously 192.168.1.100 wont register on their end. I do have a ddns address for the nas etc, so could it work through that? Or is direct paths just not possible remotely?

@im85288
Copy link
Owner

im85288 commented Jul 27, 2020

Direct paths will work remotely..but the server will switch to transcoding for remote users if needed (bandwidth etc). I share LiveTV with relatives and I know that is marked as direct playing. Movies/TVShows are transcoded as my upload limit is 4mb.

@GOvEy1nw
Copy link

GOvEy1nw commented Jul 27, 2020

Ok, I'm stuck again... I've set the network paths up in emby as follows:

\\SERVERNAME\Media\MoviesFolder\

And I've even set up the NAS to connect to Kodi. I did this in Kodi by going to File Manager > Add Source > Browse > Add network Location, and added \\SERVERNAME as the location. I also proceeded to add it as an actual source by then clicking 'OK' on that new location & ok again to add it as a source.

I've also ensured that Kodi can access this by then going into the source in file manager, locating a movie and playing it directly.

However, when I try to set Emby for Kodi to direct play, go through all the initial yes/no options, but when it comes to syncing it tells me it can't find 'XYZ' movie, please make sure kodi can see the server etc etc... Even though the movie I played through the source I added was the exact same movie, so Kodi can clearly see it.

I've also confirmed the Path Substitution is working by checking the metadata manager where I can see it's pointing to the file via the substituted network path.

I'm not sure what I can be doing wrong.

@nuentes
Copy link
Author

nuentes commented Jul 27, 2020

You might be better served in the emby forums. But when you added the network location in kodi, did you add the same exact server name? It likely would have shown up in there as smb:/SERVERNAME, or did you add by IP address? Is this an SMB share or NFS share? If NFS, are you sure the instance of Kodi has an IP that is allowed to access the server? If SMB, did you enter the credentials for the share when adding to the kodi file manager?

I believe as long as Kodi can traverse the network paths via file manager, then as long as the direct paths are using the same paths, it should work.

@im85288
Copy link
Owner

im85288 commented Jul 27, 2020

Hmm so it seems like your setup is near enough the same as mine, instead of network paths maybe set your main folders in Emby using the UNC paths, for example for tvshows I have:

\\DISKSTATION\share\TV

You do not need to add it as a source in Kodi.

I think if you do it this way (ie as the main folder in Emby) then you guarantee the Emby Server can see it as if it cannot you’ll not have any media.

@GOvEy1nw
Copy link

Hey, I've just tried setting the main folder of one of my libraries to: \\DISKSTATION\Plex Media\Kids Area\ (still got it named plex lol), but it just gave me an error saying 'The path could not be found. Please ensure the path is valid and try again.'

I've also tried it with the IP address instead and even tried it like \\DISKSTATION\Plex/ Media\Kids/ Area/ in case the spaces in the folder names were causing issues, but it says the same thing oddly...

@im85288
Copy link
Owner

im85288 commented Jul 27, 2020

So you’ve got a Synology NAS the same as me, can you map to that folder on windows for example? Maybe this is a Shield server issue..though it doesn’t make sense.

I would expect you to have to use the share folder as in my path..so for example

\\DISKSTATION\share\Plex Media\Kids Area

As all shared folders in synology are accessed that way.

@dagwieers
Copy link
Collaborator

dagwieers commented Jul 28, 2020

So, I am sorry, I have no idea what Emby exactly is so have a hard time to relate to the issue at hand.
But could it be related to a connection limit in Emby (one connection) as reported in issue #201 ?

@dagwieers dagwieers added the emby Related to Emby add-on label Jul 28, 2020
@GOvEy1nw
Copy link

GOvEy1nw commented Jul 28, 2020

So you’ve got a Synology NAS the same as me, can you map to that folder on windows for example? Maybe this is a Shield server issue..though it doesn’t make sense.

I would expect you to have to use the share folder as in my path..so for example

\\DISKSTATION\share\Plex Media\Kids Area

As all shared folders in synology are accessed that way.

Hey, yes, so I've even re-arranged all my data & folders (it was getting a little all over the place) and I've confirmed I can get to locations such as:

\\MyNas\Other_Media\Kids_Area\

Of course, at first it asks me to login, which I do, and then I can see and work with everything within that folder.

But if add that same folder to Emby (I've cleared all folders in all libraries at this point by the way) I just get the error 'The path could not be found. Please ensure the path is valid and try again.'...

I think it might be time to take this over to the Emby forums, I see that you're active over there too, hopefully we can all figure this out for the good of mankind haha.

@GOvEy1nw
Copy link

Just thinking.... Could the issue be that I'm running Emby from the NAS itself? So it can't see those folders as 'network' folders since to Emby it's all local? Seems daft if so, but just a thought...

@im85288
Copy link
Owner

im85288 commented Jul 28, 2020

@GOvEy1nw No idea why your having issues with it, agree probably best to take it to the Emby forums. I have found Emby to be pretty flakey with initial setup of shared folders sometimes...in particular it didn’t work well with the Emby server on Mac but was fine with the Emby server on Windows.

@nuentes
Copy link
Author

nuentes commented Jul 28, 2020

@dagwieers Emby is basically the same idea as Plex. It's basically a back end that takes over media management responsibilities. Also, similarly to Plex, it can serve up videos either directly or with on-the-fly transcoding. It runs on a personal server. Media from Emby can get into Kodi 1 of 2 ways. The Emby for Kodi add-on, which basically adds nodes for TV/Movie/Music so the Kodi experience is exactly the same as if the media was local. The other addon option is Embycon. This one does not create local nodes, but rather connects directly to the server and queries the server directly any time you navigate. If you've used the Kodi Netflix add-on - it's kind of like that. But again, it's hitting your personal media on your personal server.

Any connection issues with Emby would present as an issue in other ways. UpNext wouldn't really be a suspect for Emby connection issues, except in possibly rare cases with impeccable timing.

Edit - just read that other issue. I see what you're saying. My account on Emby has unlimited connections. I can watch the same show simultaneously on every device I own if I'm so inclined.

@cjk28
Copy link

cjk28 commented Aug 22, 2020

Hi, I'm having the same problem with Jellyfin, using "Native mode" as described here: https://jellyfin.org/docs/general/clients/kodi.html where the Jellyfin server, Kodi client and media is all on the same host Windows PC, anything I can do to help diagnose?

@dagwieers
Copy link
Collaborator

Please test the upcoming v1.1.3 release by testing PR #217 and reporting back.

@diabl0w
Copy link

diabl0w commented Oct 23, 2020

I have this issue as well, but I am not using any third party addon... I am playing the files natively and "locally" from an NFS share. Sometimes it does work, but only for very specific episodes of a season (and there is no difference in the codecs of the episodes, so that is not the cause. For example, letting the dialog box time out going from S01E03 -> S01E04 always works, but going from S01E04->S01E05 etc etc never works.
What happens with a working log:

2020-10-23 10:54:19.600 T:3753943936 NOTICE: [service.upnext] PlaybackManager -> played in a row settings 5
2020-10-23 10:54:19.604 T:3753943936 NOTICE: [service.upnext] PlaybackManager -> played in a row 1
2020-10-23 10:54:19.608 T:3753943936 NOTICE: [service.upnext] PlaybackManager -> showing next up page as played in a row is 1
2020-10-23 10:54:42.325 T:3588305792 NOTICE: CVideoPlayer::OnExit()
2020-10-23 10:54:42.325 T:3588305792 NOTICE: VideoPlayer: eof, waiting for queues to empty
2020-10-23 10:54:42.325 T:3588305792 NOTICE: Closing stream player 1
2020-10-23 10:54:42.325 T:3588305792 NOTICE: CDVDMessageQueue(audio)::WaitUntilEmpty
2020-10-23 10:54:42.325 T:3588305792 NOTICE: Waiting for audio thread to exit
2020-10-23 10:54:42.325 T:3481904000 ERROR: Got MSGQ_ABORT or MSGO_IS_ERROR return true
2020-10-23 10:54:42.325 T:3481904000 NOTICE: thread end: CVideoPlayerAudio::OnExit()
2020-10-23 10:54:42.326 T:3588305792 NOTICE: Closing audio device
2020-10-23 10:54:42.709 T:3588305792 NOTICE: Deleting audio codec
2020-10-23 10:54:42.709 T:3588305792 NOTICE: Closing stream player 2
2020-10-23 10:54:42.709 T:3588305792 NOTICE: CDVDMessageQueue(video)::WaitUntilEmpty
2020-10-23 10:54:43.730 T:3588305792 NOTICE: waiting for video thread to exit
2020-10-23 10:54:43.730 T:3456734080 ERROR: Got MSGQ_ABORT or MSGO_IS_ERROR return true
2020-10-23 10:54:43.730 T:3456734080 NOTICE: thread end: video_thread
2020-10-23 10:54:43.730 T:3588305792 NOTICE: deleting video codec
2020-10-23 10:54:43.806 T:4059258896 NOTICE: CVideoPlayer::CloseFile()
2020-10-23 10:54:43.807 T:4059258896 NOTICE: VideoPlayer: waiting for threads to exit
2020-10-23 10:54:43.807 T:3753943936 NOTICE: [service.upnext] PlaybackManager -> playing media episode
2020-10-23 10:54:43.807 T:4059258896 NOTICE: VideoPlayer: finished waiting
2020-10-23 10:54:43.807 T:4059258896 NOTICE: CVideoPlayer::CloseFile()
2020-10-23 10:54:43.807 T:4059258896 NOTICE: VideoPlayer: waiting for threads to exit
2020-10-23 10:54:43.807 T:4059258896 NOTICE: VideoPlayer: finished waiting
2020-10-23 10:54:43.976 T:4059258896 NOTICE: VideoPlayer::OpenFile: nfs://192.168.111.1:2049/mnt/MyCloud/Media/TVShows/Survivorman/Season 1/S01E04.mkv
2020-10-23 10:54:43.977 T:3456734080 NOTICE: Creating InputStream
2020-10-23 10:54:44.006 T:3456734080 NOTICE: Creating Demuxer
2020-10-23 10:54:44.054 T:3456734080 NOTICE: Opening stream: 0 source: 256
2020-10-23 10:54:44.054 T:3456734080 NOTICE: CVideoPlayerVideo::OpenStream - Creating codec: 27
2020-10-23 10:54:44.054 T:3456734080 NOTICE: Creating video thread
2020-10-23 10:54:44.054 T:3481904000 NOTICE: running thread: video_thread
2020-10-23 10:54:44.055 T:3456734080 NOTICE: Opening stream: 1 source: 256
2020-10-23 10:54:44.055 T:3456734080 NOTICE: Finding audio codec for: 86019
2020-10-23 10:54:44.056 T:3456734080 NOTICE: CDVDAudioCodecFFmpeg::Open() Successful opened audio decoder ac3
2020-10-23 10:54:44.056 T:3456734080 NOTICE: Creating audio thread
2020-10-23 10:54:44.056 T:3319772032 NOTICE: running thread: CVideoPlayerAudio::Process()
2020-10-23 10:54:44.068 T:3319772032 NOTICE: Creating audio stream (codec id: 86019, channels: 6, sample rate: 48000, no pass-through)
2020-10-23 10:54:44.307 T:3753943936 NOTICE: [service.upnext] UpNextMonitor -> Up Next style autoplay succeeded

A not working log:

2020-10-23 10:51:58.305 T:3753943936 NOTICE: [service.upnext] PlaybackManager -> played in a row settings 5
2020-10-23 10:51:58.309 T:3753943936 NOTICE: [service.upnext] PlaybackManager -> played in a row 1
2020-10-23 10:51:58.313 T:3753943936 NOTICE: [service.upnext] PlaybackManager -> showing next up page as played in a row is 1
2020-10-23 10:52:21.742 T:3353342848 NOTICE: CVideoPlayer::OnExit()
2020-10-23 10:52:21.742 T:3353342848 NOTICE: VideoPlayer: eof, waiting for queues to empty
2020-10-23 10:52:21.742 T:3353342848 NOTICE: Closing stream player 1
2020-10-23 10:52:21.743 T:3353342848 NOTICE: CDVDMessageQueue(audio)::WaitUntilEmpty
2020-10-23 10:52:21.775 T:3353342848 NOTICE: Waiting for audio thread to exit
2020-10-23 10:52:21.776 T:3336557440 ERROR: Got MSGQ_ABORT or MSGO_IS_ERROR return true
2020-10-23 10:52:21.776 T:3336557440 NOTICE: thread end: CVideoPlayerAudio::OnExit()
2020-10-23 10:52:21.776 T:3353342848 NOTICE: Closing audio device
2020-10-23 10:52:21.934 T:3753943936 NOTICE: [service.upnext] PlaybackManager -> playing media episode
2020-10-23 10:52:22.008 T:4059258896 NOTICE: VideoPlayer::OpenFile: nfs://192.168.111.1:2049/mnt/MyCloud/Media/TVShows/Survivorman/Season 1/S01E05.mkv
2020-10-23 10:52:22.014 T:3753943936 NOTICE: [service.upnext] UpNextMonitor -> Up Next style autoplay succeeded
2020-10-23 10:52:22.226 T:3353342848 NOTICE: Deleting audio codec
2020-10-23 10:52:22.226 T:3353342848 NOTICE: Closing stream player 2
2020-10-23 10:52:22.226 T:3353342848 NOTICE: CDVDMessageQueue(video)::WaitUntilEmpty
2020-10-23 10:52:22.815 T:3353342848 NOTICE: waiting for video thread to exit
2020-10-23 10:52:22.815 T:3344950144 ERROR: Got MSGQ_ABORT or MSGO_IS_ERROR return true
2020-10-23 10:52:22.815 T:3344950144 NOTICE: thread end: video_thread
2020-10-23 10:52:22.815 T:3353342848 NOTICE: deleting video codec
2020-10-23 10:52:22.877 T:4059258896 NOTICE: CVideoPlayer::CloseFile()
2020-10-23 10:52:22.878 T:4059258896 NOTICE: VideoPlayer: waiting for threads to exit
2020-10-23 10:52:22.878 T:4059258896 NOTICE: VideoPlayer: finished waiting
2020-10-23 10:52:22.878 T:4059258896 NOTICE: CVideoPlayer::CloseFile()
2020-10-23 10:52:22.878 T:4059258896 NOTICE: VideoPlayer: waiting for threads to exit
2020-10-23 10:52:22.878 T:4059258896 NOTICE: VideoPlayer: finished waiting

As you can see, in the working version, up next doesnt try to open the new file until after "finished waiting", but it seems like in the failed version it tries to open the file before kodi is finished closing the previous video

And I would like to reemphasize that this is very reproduceable, always works with S01E03 and never works with most other episodes that I've tried, and yes I tried changing watch statuses and kodi settings related to "default select action" etc etc

@diabl0w
Copy link

diabl0w commented Oct 23, 2020

And for the good news, I git pulled the current master branch and the issue has been fixed!

@cjk28
Copy link

cjk28 commented Oct 26, 2020

Confirmed fixed for me too. Potentially not directly related, if I jump to the end of an episode by skipping (e.g. pressing up on the remote to skip to the end), the add-on will not be invoked and therefore the next episode won't be played (unless we are already in a playlist, which for my use case of generally launching a show from the "TV shows -next episodes"widget is not the case. Could that be handled by the add-on?

@dagwieers
Copy link
Collaborator

We planned to do a new release this weekend. I did not make it, but it will be there ASAP.

Could that be handled by the add-on?

Please open a new issue for this.

@popy2k14
Copy link

Any news for this issue.
This also doesn't autoplay for me on the end of an episode. When I press the next button, it works.
Thx

@MoojMidge
Copy link
Collaborator

@popy2k14 What version are you using?

@popy2k14
Copy link

popy2k14 commented Dec 28, 2020

Newest v1.1.4 on Leia v18.9 with newest emby for kodi addon.

@MoojMidge
Copy link
Collaborator

Can you provide a debug log? The fixes discussed here either involved changing the way Emby was integrated with Kodi or using a playlist generated by UpNext to queue and play the next episode.

Either of these fixes should work for the majority of cases, however there were additional edge cases where one or more of the following could occur:

  • addon data was received after onPlaybackStarted had already been called
  • incorrect callbacks were being called when there was a playback error
  • expected order of callbacks being called in UpNext logic was not consistent with actual order of callbacks being called by Kodi
  • video stream info had not fully loaded when onPlaybackStarted or onAVStarted had been called resulting in UpNext thinking that the stream duration was zero

Need more information to determine exactly what the problem is in your case.

@cjk28
Copy link

cjk28 commented Feb 25, 2021

This seems to have returned for me after updating to Kodi 19.0. I have 1.1.5 of the addon.
log with upnext debug enabled and just opened kodi, played one episode, let the timer expire, expected next episode, but playback ends. jellyfin for kodi seems a bit unhappy at a glance of the log so maybe that is part of the problem
kodi.log

@MoojMidge
Copy link
Collaborator

For some reason your played in a row setting has been set to zero, so the Still Watching? popup is always showing, not the Up Next popup.

If there is no user interaction on the Still Watching? popup then playback will stop.

You need to change the setting for Number of episodes before "Still there?" query to something other than zero

@cjk28
Copy link

cjk28 commented Feb 25, 2021

Thanks for the quick reply and analysis! that has indeed fixed it, although i hadn't changed my settings, so I believe i had it set to 0 before and it was working, despite definitely seeing the "still watching?" popup.

Either way the settings/behaviour on this topic are a bit unclear, it would be good if the settings page could be reworked a bit to make this more obvious.
thanks again!

@MoojMidge
Copy link
Collaborator

MoojMidge commented Feb 26, 2021

Yeah that was one of the issues that was also fixed in v1.1.5 - playback would not stop after Still Watching? popup was shown.

I think there are a few opportunities to improve the Still Watching? functionality:

  • currently the comparison of played episodes is made to played_in_a_row_number + 1 (effectively, the actual comparison is played_in_a_row <= played_in_a_row_number) which means that a user would set the Number of episodes before "Still there?" query setting to 3, for example, but the Still Watching? popup would only show up if 4 episodes have played and the 5th episode was about to play. This doesn't seem correct to me.
  • There is no way to disable the Still Watching? popup. Setting to zero should disable it. Setting to one should mean it appears all the time.
  • Tidy up wording and add more description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working emby Related to Emby add-on
Projects
None yet
Development

No branches or pull requests

8 participants