Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression (only in git): some files fail to decode #40

Closed
Shnatsel opened this issue Dec 1, 2024 · 1 comment · Fixed by #41
Closed

Regression (only in git): some files fail to decode #40

Shnatsel opened this issue Dec 1, 2024 · 1 comment · Fixed by #41

Comments

@Shnatsel
Copy link
Contributor

Shnatsel commented Dec 1, 2024

#39 seems to have caused a regression. Some PNGs now fail to decode with this error:

called Result::unwrap() on an Err value: Decoding(DecodingError { format: Exact(Png), underlying: Some(Format(FormatError { inner: CorruptFlateStream { err: InvalidUncompressedBlockLength } })) })

Here's a couple samples triggering the issue: fdeflate_decode_failures_67100397.zip

Tested with https://github.com/fintelia/corpus-bench

These files are from my web-scraped corpus which you can download and try locally yourself. It is 58,000 files but most of them are very small so decoding all of them only takes a few minutes.

@fintelia
Copy link
Contributor

fintelia commented Dec 1, 2024

Thanks for reporting! Seems it was a small oversight in not initializing the eof mask/length when using the precomputed tables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants