Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Naming #2

Open
jeffturcotte opened this issue Nov 7, 2017 · 2 comments
Open

Better Naming #2

jeffturcotte opened this issue Nov 7, 2017 · 2 comments
Labels
enhancement

Comments

@jeffturcotte
Copy link
Member

jeffturcotte commented Nov 7, 2017 •
edited
Loading

vuexModule, vueMixin, etc. are too generic IMO. I don't know for sure what would be better, but here are some suggestions:

ClockvineStore (capitalized as it is a class)
clockvineModel
clockvineEditableModel
@khamer
Copy link
Member

khamer commented Nov 10, 2017

I agree – I'm going to make 0.4 or 0.5 break backwards compatibility, and I'll do something like this then.

@khamer
Copy link
Member

khamer commented Jan 21, 2022

So, I did change the names, but didn't namespace them. It seems to me like

import { CollectionComponent } from 'clockvine-vue'

Is reasonable and consistent. If anything, I think I should try to publish as just 'clockvine'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khamer @jeffturcotte