Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footnotes within callout shortcodes do not render correctly #379

Open
ahgraber opened this issue May 2, 2024 · 3 comments
Open

footnotes within callout shortcodes do not render correctly #379

ahgraber opened this issue May 2, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@ahgraber
Copy link

ahgraber commented May 2, 2024

Description

Footnote notation [^3] in callout shortcodes do not seem to be identified correctly; do not get included in footnotes.

Steps To Reproduce

  1. Post and commit of the issue - https://github.com/ahgraber/AIMLbling-about/blob/a8f21e74308c0aad446d9b29b72922c767fcd2d2/content/blog/the-compounding-error-of-generative-models/index.md

Expected Behavior

The footnote link should be superscripted and the footnote should be included.

Actual Behavior

The footnote link was left as plaintext "[^3]" and the footnote was not rendered

Screenshots

footnote link unrecognized
image

footnote is not included (link should be 3 and it is missing)
image

raw text of what should render
image

Environment

  • hugo v0.124.1+extended darwin/arm64; blog is prerendered into a docker container
  • Browser: Arc, Safari, Firefox
  • Theme Version: v0.7.3

Additional Context

@imfing imfing added the bug Something isn't working label May 16, 2024
@imfing
Copy link
Owner

imfing commented May 16, 2024

Hi @ahgraber thank you for reporting this.

Currently the callout shortcode doesn't have the context of its parent page, thus the footnote was not correctly parsed along with other ones in the parent page.

I'll see what I could do to fix it.

@ahgraber
Copy link
Author

@imfing Thanks! I saw comments on hugo forums about the same; it seems like it might require jumping through a lot of hoops to provide the parent context, which might induce a lot of edge cases? If this becomes a wontfix because of the trouble, I fully understand!

@imfing
Copy link
Owner

imfing commented May 29, 2024

I'd keep this open, while waiting to see if there could be any solutions from Hugo community in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants