Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra white space under merged event in Month view #10

Open
dandv opened this issue Apr 17, 2015 · 7 comments
Open

Extra white space under merged event in Month view #10

dandv opened this issue Apr 17, 2015 · 7 comments
Labels

Comments

@dandv
Copy link

dandv commented Apr 17, 2015

image

@imightbeamy
Copy link
Owner

Hey @dandv, thanks for reporting this. Unfortunately, the limitation of this being an extension makes this issue hard to fix and it's unlikely that I'll be able to fix it well. That being said, whenever I get some time to look into it I will.

@pconwell-old
Copy link

I don't have a solution to this, but I had an observation. I was seeing the same issue, but completely unrelated to that issue, I changed my calendar's color then accidentally hid and unhid the calendar. Somehow in that process, when I refreshed the month view, it is now displaying correctly for me.

@bpearson
Copy link

bpearson commented May 1, 2016

@imightbeamy Can you still look into this? I have too many calendars to use the workaround and this can sometimes hide non-related events by the extra whitespace from the merged events.

Also on my cal, I can see the arrow for "not responded yet". And when you hover over the whitespace, the guest icon pops up.
screenshot_2016-05-01_19-02-44

@Shtutnik
Copy link

Shtutnik commented May 4, 2016

@bpearson pull request #25 should fix what you are seeing, from my understanding

@imightbeamy
Copy link
Owner

The arrow icons appearing is a separate issue from the extra whitespace. The arrows are a bug that need to get fixed, as I said before the pre-existing extra whitespace is limitation of this being an extension. Even if the whitespace was removed, it's complex to pull in the events that are hidden because they aren't loaded on the page until you click to see more on the day.

@Shtutnik
Copy link

I agree with @imightbeamy.
The only way to do this, in my opinion, is to put a hook on the function that enumerates the events before building the different views and to do the merge of the events in that context. This way, the events would be merged as objects in the code before the view is built, so the functions that build the view would "see" the already merged events, which will solve the issue mentioned here.
But since this extension's solution is built on the end-result view, developing such a technique would probably only be worth if a whole different extension were developed.

@dzoech
Copy link

dzoech commented Mar 12, 2019

Since this issue is from 2016 and in the meantime the new UI was introduced, I'd like to ask if the limitations stayed the same or if this is now possible to fix somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants