Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In2code\Femanager\Domain\Validator\ServersideValidator::getValue(): Return value must be of type string|bool, int returned #539

Closed
pfuju opened this issue Jan 18, 2024 · 6 comments
Milestone

Comments

@pfuju
Copy link
Contributor

pfuju commented Jan 18, 2024

Hello
there seems to be a bug in the ServersideValidator::getValue(), which requires a return value of type string or bool.
In case of additional fields should be validated like gender (int), etc. this funtions throws an exception.
Type decleration should be removed!

@mhuber84
Copy link
Contributor

I can confirm this error

@tmhf
Copy link

tmhf commented Feb 7, 2024

I also can confirm this error (TYPO3 12.4.9, femanager 8.0.1)

@hannesbochmann
Copy link
Contributor

I can confirm this error, too.

@hannesbochmann
Copy link
Contributor

For everybody needing a fast fix, this patch will do it. But it's for sure no good fix.
femanager.issue-539.txt

@giesenmartin
Copy link

giesenmartin commented Apr 9, 2024

I can also confirm this issue. An Integer should be added to the return values of the getValue method. If the property is an Object or an ObjectStorage, an Integer value should be returned.

Edit: In the main branch, the return type has already been changed to mixed.

@pixeldesu
Copy link
Member

This has been fixed in https://github.com/in2code-de/femanager/releases/tag/8.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants