Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix current/previous/next playlist building when current clip is blank media #107

Open
Lacrymology opened this issue Jun 14, 2013 · 3 comments

Comments

@Lacrymology
Copy link
Contributor

Current playlist should show "INVALID" and previous and next playlists should be found by date

@Lacrymology
Copy link
Contributor Author

with the current setup, this should be handled by caspa.

When mosto doesn't know about the show (it's not loaded in the playlists collection), it sends an empty object {}, when it's an invalid show (a clip with no playlist, like BlankClip), it sends _id: -1, otherwise, it sends _id: <schedule id>

I'm not convinced this is the right approach, but a communications protocol was never properly designed.

In any case, this will have to wait until the new caspa is merged

@jmrunge
Copy link
Member

jmrunge commented Sep 18, 2013

Why does caspa never (or almost never) show previous clip and previous
show? Are we sure we are sending them? (thats why I left this issue
opened, I wanted to make sure of this).

2013/9/17 Tomas Neme [email protected]

with the current setup, this should be handled by caspa.

When mosto doesn't know about the show (it's not loaded in the playlists
collection), it sends an empty object {}, when it's an invalid show (a
clip with no playlist, like BlankClip), it sends _id: -1, otherwise, it
sends _id:

I'm not convinced this is the right approach, but a communications
protocol was never properly designed.

In any case, this will have to wait until the new caspa is merged


Reply to this email directly or view it on GitHubhttps://github.com//issues/107#issuecomment-24623219
.

@Lacrymology
Copy link
Contributor Author

no, we're not, because in most cases previous clip / show are not loaded into mosto. The fact that invalid show sends id = -1 and unknown sends {} is so caspa can look for the expected previous show.

I don't know what's the right behavior here. If we should show the historically previous show, whatever the programming says, we need to keep track of this somewhere, and keep it between mosto reboots, and whatnot. Right now what's being sent is what mosto has loaded in it's Playlists and MeltedMedia backbone collections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants