Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate changes from mongo driver to json driver #37

Open
jmrunge opened this issue Apr 9, 2013 · 11 comments
Open

Replicate changes from mongo driver to json driver #37

jmrunge opened this issue Apr 9, 2013 · 11 comments
Assignees
Labels
Milestone

Comments

@jmrunge
Copy link
Member

jmrunge commented Apr 9, 2013

Replicate all changes made to mongo driver into json driver, in order to keep them changeable.

@ghost ghost assigned jmrunge Apr 9, 2013
@xaiki
Copy link
Member

xaiki commented Apr 9, 2013

On 9 April 2013 09:03, Juan Martin Runge [email protected] wrote:

Replicate all changes made to mongo driver into json driver, in order to
keep them changeable.

that is basically:

  • write a 'in driver' test.
  • make json driver pass the test.

Niv Sardi

@jmrunge
Copy link
Member Author

jmrunge commented Apr 9, 2013

Agree!

Enviado desde mi BlackBerry

-----Original Message-----
From: Niv Sardi [email protected]
Date: Tue, 09 Apr 2013 09:18:06
To: inaes-tic/[email protected]
Reply-To: inaes-tic/mbc-mosto [email protected]
Cc: Juan Martin [email protected]
Subject: Re: [mbc-mosto] Replicate changes from mongo driver to json driver
(#37)

On 9 April 2013 09:03, Juan Martin Runge [email protected] wrote:

Replicate all changes made to mongo driver into json driver, in order to
keep them changeable.

that is basically:

  • write a 'in driver' test.
  • make json driver pass the test.

Niv Sardi


Reply to this email directly or view it on GitHub:
#37 (comment)

@Lacrymology
Copy link
Contributor

This depends on #44

@xaiki
Copy link
Member

xaiki commented Apr 20, 2013

status?

On 11 April 2013 15:08, Tomas Neme [email protected] wrote:

This depends on #44 #44


Reply to this email directly or view it on GitHubhttps://github.com//issues/37#issuecomment-16251569
.

Niv Sardi

@jmrunge
Copy link
Member Author

jmrunge commented Apr 23, 2013

Status @Lacrymology ? I think #44 was solved already...

@Lacrymology
Copy link
Contributor

Do we keep the JSON driver?

@xaiki
Copy link
Member

xaiki commented Sep 17, 2013

no if we have a replacement as a test harness to test the rest of the code.

On 17 September 2013 17:07, Tomas Neme [email protected] wrote:

Do we keep the JSON driver?


Reply to this email directly or view it on GitHubhttps://github.com//issues/37#issuecomment-24618004
.

Niv Sardi

@Lacrymology
Copy link
Contributor

hm, all I can say right now is that current tests go through 46% of mongo playlists driver, but nothing of json driver

I'm not sure what we're testing or not testing with(out) going through any playlists drivers.

Parts of the functional test (specifically the ones that depend on the playlist driver) are not running yet (because they will depend on changes in caspa)

@jmrunge
Copy link
Member Author

jmrunge commented Sep 18, 2013

I would like to keep the JSON driver. Its not only a way to test mosto,
its also a way to easily use mosto without caspa.

2013/9/17 Tomas Neme [email protected]

hm, all I can say right now is that current tests go through 46% of mongo
playlists driver, but nothing of json driver

I'm not sure what we're testing or not testing with(out) going through any
playlists drivers.

Parts of the functional test (specifically the ones that depend on the
playlist driver) are not running yet (because they will depend on changes
in caspa)


Reply to this email directly or view it on GitHubhttps://github.com//issues/37#issuecomment-24621982
.

@xaiki
Copy link
Member

xaiki commented Sep 18, 2013

If it's only for mosto without caspa we let it die,... The overhead is toó
high right now.

Again, either we do the same with our test harness or we fix it.

Niv Sardi, mobile.
On Sep 17, 2013 11:38 PM, "Juan Martin Runge" [email protected]
wrote:

I would like to keep the JSON driver. Its not only a way to test mosto,
its also a way to easily use mosto without caspa.

2013/9/17 Tomas Neme [email protected]

hm, all I can say right now is that current tests go through 46% of
mongo
playlists driver, but nothing of json driver

I'm not sure what we're testing or not testing with(out) going through
any
playlists drivers.

Parts of the functional test (specifically the ones that depend on the
playlist driver) are not running yet (because they will depend on
changes
in caspa)


Reply to this email directly or view it on GitHub<
https://github.com/inaes-tic/mbc-mosto/issues/37#issuecomment-24621982>
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/37#issuecomment-24637357
.

@jmrunge
Copy link
Member Author

jmrunge commented Sep 18, 2013

I think there is no overhead... let me take a look at it and write its
test... it should not take more than 2 hours.

2013/9/18 Niv Sardi [email protected]

If it's only for mosto without caspa we let it die,... The overhead is toó
high right now.

Again, either we do the same with our test harness or we fix it.

Niv Sardi, mobile.
On Sep 17, 2013 11:38 PM, "Juan Martin Runge" [email protected]
wrote:

I would like to keep the JSON driver. Its not only a way to test mosto,
its also a way to easily use mosto without caspa.

2013/9/17 Tomas Neme [email protected]

hm, all I can say right now is that current tests go through 46% of
mongo
playlists driver, but nothing of json driver

I'm not sure what we're testing or not testing with(out) going through
any
playlists drivers.

Parts of the functional test (specifically the ones that depend on the
playlist driver) are not running yet (because they will depend on
changes
in caspa)


Reply to this email directly or view it on GitHub<
https://github.com/inaes-tic/mbc-mosto/issues/37#issuecomment-24621982>
.


Reply to this email directly or view it on GitHub<
https://github.com/inaes-tic/mbc-mosto/issues/37#issuecomment-24637357>
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/37#issuecomment-24660438
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants