Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid needing to call jsx:decode/1 more than once per request. #117

Open
HernanRivasAcosta opened this issue Sep 13, 2016 · 0 comments
Open
Assignees

Comments

@HernanRivasAcosta
Copy link
Member

egithub_webhook:request() should be opaque and have this spec: #{headers => map(), body => map() | binary()}.

Use a function to get the body which always returns a map and if the body in the request is a binary, parses it and returns the new request. Similar to what cowboy does.

@jfacorro jfacorro changed the title Avoid needing to call jiffy:decode/1 more than once per request. Avoid needing to call jsx:decode/1 more than once per request. Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants