Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the expected return on egithub_webhook #21

Open
elbrujohalcon opened this issue Jan 13, 2015 · 1 comment
Open

Simplify the expected return on egithub_webhook #21

elbrujohalcon opened this issue Jan 13, 2015 · 1 comment

Comments

@elbrujohalcon
Copy link
Member

Instead of requesting the callback module to find out the commit_id and the position let the module just return filename, line_number and text and do the rest of the processing inside egithub_webhook (use the current implementation in elvis_webhook as a reference).

@elbrujohalcon
Copy link
Member Author

Also, make sure CommitId is always a binary and not a string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant