Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spec generation #13

Open
elbrujohalcon opened this issue Oct 4, 2018 · 0 comments
Open

Fix spec generation #13

elbrujohalcon opened this issue Oct 4, 2018 · 0 comments
Labels
hacktoberfest Ideas for Hacktoberfest

Comments

@elbrujohalcon
Copy link
Member

As described in #7, since #3 mixer is inserting generic specs for every function added.
That effectively prevents compiler warnings when warn_missing_spec is on, but messes up with dialyzer when, for instance, you're mixing in a function that implements a callback defined in a behavior (such situation will lead to warnings like The return type any() in the specification of your_function/1 is not a subtype of another_type(), which is the expected return type for the callback of your behaviour). That's not good.

The best thing to do would be, of course, to import the specs from the source module along with the functions. That might not be possible. If that's so… we should at least make spec additions configurable.

@elbrujohalcon elbrujohalcon added the hacktoberfest Ideas for Hacktoberfest label Oct 4, 2018
elbrujohalcon added a commit that referenced this issue Oct 8, 2018
[#13] Initial attempt at fixing spec generation
@elbrujohalcon elbrujohalcon modified the milestone: 1.1.0 Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Ideas for Hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant