From d80df4d1ef8a94a25e2ea0857f504dad31a0f232 Mon Sep 17 00:00:00 2001
From: Damiano Oldoni <damiano.oldoni@inbo.be>
Date: Mon, 17 Jul 2023 11:40:42 +0200
Subject: [PATCH] Add some warnings in conversion metadata

---
 R/zzz.R | 38 ++++++++++++++++++++++++++++++++++----
 1 file changed, 34 insertions(+), 4 deletions(-)

diff --git a/R/zzz.R b/R/zzz.R
index 353c0093..a80be4d2 100644
--- a/R/zzz.R
+++ b/R/zzz.R
@@ -502,12 +502,42 @@ convert_to_0.1.6 <- function(package, from = "1.0-rc.1"){
 #' @noRd
 #' @importFrom dplyr %>% .data
 convert_metadata_to_0.1.6 <- function(package, from = "1.0-rc.1"){
+  authors <- purrr::map_df(package$contributors, unlist)
+  if ("role" %in% names(authors)) {
+    deprecated_roles <- c("author", "maintainer")
+    if (any(deprecated_roles %in% authors$role)) {
+      warning(paste0(
+        "Roles ",
+        glue::glue_collapse(glue::glue("{deprecated_roles}"), 
+                            sep = " ",
+                            last = " and "),
+        " are deprecated in ",
+        "version {from}."
+        )
+      )
+    }
+  }
+  if ("organizations" %in% names(package)) {
+    warning(glue::glue(
+      "The field `organizations` is deprecated in ",
+      "version {from}."
+      )
+    )
+  }
+  if ("animalTypes" %in% names(package)) {
+    warning(glue::glue(
+      "The field `animalTypes` is deprecated in",
+      "version {from}."
+      )
+    )
+  }
   names(package)[names(package) == "observationLevel"] <- "classificationLevel"
-  if ("sequenceInterval" %in% names(package)) {
-    warning(glue::glue("sequenceInterval is deprecated in version ", 
-                       "{from}: removed from package.")
+  if ("sequenceInterval" %in% names(package$project)) {
+    warning(glue::glue(
+      "The field `sequenceInterval` is deprecated in",
+      "version {from}."
+      )
     )
-    package$sequenceInterval <- NULL
   }
   package$platform <- package$sources[[1]]$title
   # `title` value of the first contributor with role `rightsHolder`