Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results on pkgdown website link to wrong page #197

Closed
3 tasks done
peterdesmet opened this issue Feb 23, 2023 · 6 comments
Closed
3 tasks done

Search results on pkgdown website link to wrong page #197

peterdesmet opened this issue Feb 23, 2023 · 6 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone

Comments

@peterdesmet
Copy link
Member

peterdesmet commented Feb 23, 2023

  1. Go to https://inbo.github.io/camtraptor/index.html
  2. Type "Read" in the search bar at the top
  3. Click on the first suggested result in the dropdown: Reference > Read a Camtrap DP — read_camtrap_dp
  4. Result link to: https://inbo.github.io/reference/read_camtrap_dp.html?q=Read#null

Rather than the expected: https://inbo.github.io/camtraptor/reference/read_camtrap_dp.html?q=Read#null

This also affects:

frictionless, bioRad, wateRinfo and rgbif are not affected.

@PietrH can you debug this one?

@peterdesmet peterdesmet added bug Something isn't working documentation Improvements or additions to documentation labels Feb 23, 2023
@peterdesmet peterdesmet added this to the v0.20 milestone Feb 23, 2023
@PietrH
Copy link
Member

PietrH commented Feb 23, 2023

I'm having a look

@PietrH
Copy link
Member

PietrH commented Feb 27, 2023

I'm having trouble replicating this, it's possibly due to url: ~ in _pkgdown.yml, however I haven't been able to test this hypothesis. I've found examples of similar _pkgdown.yml on github that do seem to work, but that's possibly because they pages were built before a breaking change somewhere in the stack. Or it might be something else entirely.

Later on this week I'll have another go at this issue.

@peterdesmet
Copy link
Member Author

Oh, that's a good guess. I'm curious if anyone has reported it at pkgdown.

@PietrH
Copy link
Member

PietrH commented Feb 28, 2023

@damianooldoni and I had a brief discussion about this issue today.

To clarify: I can confirm the issue, but haven't been able to create a new website with pkgdown that has the same problem.

So far I've been debugging off a fork of existing packages with the issue, but later on this week I'll try starting from a blank slate (a new, repo, a new package). Thanks for the suggestion.

@damianooldoni damianooldoni modified the milestones: v0.20, v1.0 Jul 6, 2023
@PietrH
Copy link
Member

PietrH commented Jul 6, 2023

Discussed with @damianooldoni, to move to milestone v1.0

peterdesmet added a commit to trias-project/trias that referenced this issue Sep 6, 2023
peterdesmet added a commit to inbo/movepub that referenced this issue Sep 6, 2023
@peterdesmet
Copy link
Member Author

This is now fixed. It is indeed necessary to change url: ~ to an absolute domain name. I have also updated (or recorded to update) the other packages this affects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants