-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create mica
from example dataset in Camtrap DP
#220
Comments
In general I agree with @peterdesmet 👍
mica_zenodo_5590881 is not needed and indeed is too big. I have used it while writing some functions as I needed bigger and more complex datapackages. But this doesn't justify its presence in |
Tests to verify
Example to verify
|
For reference, the deployments were changed as follows from old to new:
|
@PietrH @damianooldoni I have reviewed all examples and tests
|
Thanks @peterdesmet. I will give a look to the failing tests asap. About the need to store something in |
About failure in test-get_obs, the problem seems that I count number of distinct |
This fixes failure in test-get_n_species, related to #220
I don't know what meaning users subscribe to "number of observations". See this example, which has 1 Ardea cinerea, 1 female Anas platyrhynchos, 1 male Anas platyrhynchos. If you group by deployment and scientificName, you will get (for this sequence alone):
Note that this assumes you only use event-based observations. If you count media-based observations, you will get (for this sequence alone):
In my opinion:
|
camtrapdp now uses the Camtrap DP example dataset via |
See #312. We close this issue as not relevant anymore. |
Rather than maintaining our own example dataset in
inst/extdata
, I suggest to createmica
from the example dataset in Camtrap DP (also derived from the mica project), which lives https://github.com/tdwg/camtrap-dp/tree/main/example. It is versioned and valid with the format, so https://github.com/tdwg/camtrap-dp/tree/1.0-rc.1/example follows the1.0-rc.1
specs. It is also complete and covers a number of use cases.read_camtrap_dp()
tests to make use of a temp download: 10 failsproblems()
inread_camtrap_dp()
, but as discussed with @damianooldoni it's not worth it for that.problems()
could be explained with plain text in the exampleread_camtrap_dp()
parsing issues test: 1 failmica
dataset was obtained.The text was updated successfully, but these errors were encountered: