-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checks of camtrap DP input #299
Comments
I think the check function itself should be provided by camtrapdp. I just created this issue: inbo/camtrapdp#21 I'm a bit curious why you want to check the version of the object. The version will be assigned to the camtrapdp object by |
Because of #298. |
I agree it's within the spirit of "fail early" to check if the object offered to camtraptor is actually a camtrapdp. However, we need to keep in mind that some users might want to create a camtrapdp object manually in memory, so I would keep it as simple as possible. So maybe check for the class but not the version? |
Update: we decided to reexport reading functionlality of camtrapdp in camtraptor version 1.0, so the camtrap DPs will be checked while reading them using the camtraptor function |
camtraptor will not support reading functionalities. All its functions where a Camtrap DP is passed as argument should implement two checks:
c("camtrapdp" "list")
attributes(dp)
) is one of the supported versions: we will support version 1.0.The text was updated successfully, but these errors were encountered: