New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include cassis #4

Open

veganstraightedge opened this issue Apr 12, 2016 · 4 comments

Contributor

veganstraightedge commented Apr 12, 2016

Or document that cassis needs to be loaded to use this library.

As far as I can tell, this line won't work unless cassis is loaded by this library or by whatever app loads this library.

https://github.com/indieweb/link-rel-parser-php/blob/master/src/IndieWeb/link_rel_parser.php#L43

veganstraightedge changed the title ~~Load cassis~~ Include cassis

Member

tantek commented Apr 12, 2016

I think a README note should suffice for now. link-rel-parser-php was intended as code sharing, not any attempt of making something standalone

Contributor Author

veganstraightedge commented Apr 14, 2016

@tantek: I'll leave to you.

Member

tantek commented Nov 2, 2016

Added comments to both link_rel_parser.php and get_rel_webmention.php both explicitly documenting their dependencies on CASSIS:
https://github.com/indieweb/link-rel-parser-php/blob/master/src/IndieWeb/link_rel_parser.php#L7
https://github.com/indieweb/link-rel-parser-php/blob/master/src/IndieWeb/get_rel_webmention.php#L8

lostfocus commented Jan 2, 2017

Probably wouldn't hurt to add that dependency to the composer.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment