Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lifetime of SVM wrapper objects shouldn't matter #378

Closed
inducer opened this issue Sep 9, 2020 · 1 comment
Closed

Lifetime of SVM wrapper objects shouldn't matter #378

inducer opened this issue Sep 9, 2020 · 1 comment

Comments

@inducer
Copy link
Owner

inducer commented Sep 9, 2020

It currently does, cf. the crashes observed for #377.

As far as I can tell, the problem with this style of SVM usage is that the SVM object holds on to a Py_buffer that gets freed before its time. Fixing this properly would require the nanny event to accept a variable number of SVM objects and wait on the operation to complete before letting them go.
inducer added a commit that referenced this issue Sep 9, 2020
@inducer
Fix crashes in read-only SVM test (cf gh-378)
2e25bd4
inducer added a commit that referenced this issue Sep 9, 2020
@inducer
Merge pull request #379 from inducer/fix-ro-svm-crashes
c2905e4 
Fix crashes in read-only SVM test (cf gh-378)
@inducer
Copy link
Owner Author

inducer commented Sep 16, 2022

Resolved in #452.

@inducer inducer closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@inducer