Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rcodesign should error if no private key pem file is specified #176

Open
amgdev9 opened this issue Jan 2, 2025 · 1 comment
Open

rcodesign should error if no private key pem file is specified #176

amgdev9 opened this issue Jan 2, 2025 · 1 comment
Labels
apple-codesign apple-codesign crate and rcodesign CLI tool

Comments

@amgdev9
Copy link

amgdev9 commented Jan 2, 2025

If I do rcodesign sign --pem-file cert.pem MyApp.app, being cert.pem a regular certificate pem file, the tool should print an error indicating that no private key has been specified. Right now it just goes on and leaves the app executable partially unsigned.
@indygreg indygreg added the apple-codesign apple-codesign crate and rcodesign CLI tool label Jan 2, 2025
@indygreg
Copy link
Owner

indygreg commented Jan 2, 2025

I think that providing a public certificate without its signing key should be a fatal error. Thanks for filing the issue!

@amgdev9 amgdev9 changed the title rcodesign should error is no private key pem file is specified rcodesign should error if no private key pem file is specified Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apple-codesign apple-codesign crate and rcodesign CLI tool
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@indygreg @amgdev9