Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toUint256() function should return the number without the floating part #12

Open
FabienCoutant opened this issue Sep 18, 2022 · 0 comments

Comments

@FabienCoutant
Copy link

Thanks to the great lib.

I just have one remark.
I expected the toUint256() function to return the number rounded as Uint256.
For example: passing 12,3456 I expect to get 12 from toUint256()
To get the right result I have to pass my 12,3456 into the toFelt() function and then the toUint256().

Also we can add what type of rounding we want as param to the function.

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant