Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line graph shading should not be limited to just vertical shading #669

Open
TCL735 opened this issue Aug 26, 2021 · 1 comment
Open

Line graph shading should not be limited to just vertical shading #669

TCL735 opened this issue Aug 26, 2021 · 1 comment

Comments

@TCL735
Copy link
Contributor

TCL735 commented Aug 26, 2021

Line graph shading is very primitive and needs improvement. The "shadeBelow" option is very literal. It does not care that a line graph can be flipped sideways (time as the y-axis, value as the x-axis).

Proposal: "shadeBelow" should be smarter: allow the user to specify the shaded dimension, and have sensible defaults that follows the time axis by shading appropriately.

Here is an example of incorrect shading when time axis is flipped with the value axis:
Screen Shot 2021-08-26 at 10 00 32 AM

The correct shading would be shading that goes from the vertical axis' border on the left to the line points, ie left-to-right shading.

@TCL735
Copy link
Contributor Author

TCL735 commented Aug 26, 2021

Related to #668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant