Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default tags overrided user's tags #174

Open
fffx opened this issue Jul 21, 2021 · 1 comment
Open

Default tags overrided user's tags #174

fffx opened this issue Jul 21, 2021 · 1 comment

Comments

@fffx
Copy link

fffx commented Jul 21, 2021

When I use InfluxDB::Rails.instrument in a background process, I would like to override the default location

InfluxDB::Rails.instrument "expensive_operation", tags: {location: "Foo#bar }, values: { } do
  expensive_operation
end

but the location tag will override by raw. Could consider change config.tags_middleware.call(tags.merge(default_tags))
to config.tags_middleware.call(default_tags.merge(tags)) ?

@ChrisBr
Copy link
Collaborator

ChrisBr commented Jul 21, 2021

I think this makes sense. I can change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants