Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherited fields are not pached when using django-modeltranslation > 0.19.0 #429

Open
tognee opened this issue Jul 3, 2024 · 4 comments · May be fixed by #433
Open

Inherited fields are not pached when using django-modeltranslation > 0.19.0 #429

tognee opened this issue Jul 3, 2024 · 4 comments · May be fixed by #433

Comments

@tognee
Copy link

tognee commented Jul 3, 2024

Fields like title and slug are not being patched in wagtail admin page due to django-modeltranslation splitting the fields attribute into local_fields and all_fields.

I've been able to fix this by replacing all instances of translator.get_options_for_model(...).fields into translator.get_options_for_model(...).all_fields

@jorenham
Copy link
Contributor

Care to submit a PR for this?

@tognee
Copy link
Author

tognee commented Jul 12, 2024

Hi, should the PR be retrocompatibile with old versions of the library or it just changes all instances of the attribute and add a new minimum version library requirement?

@jorenham
Copy link
Contributor

Judging by previous releases, I believe it's fine to just set django-modeltranslation>=0.19. Maybe it's also wise to add an upper bound while you're at it, so that something like this wont happening again in the future.

Perhaps @DiogoMarques29 can say more about this

@DiogoMarques29
Copy link
Collaborator

Hello!

We can add that requirement to version 0.15.2. Version 0.16 will be reserved for the new Wagtail LTS (currently version 5.2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants